Page MenuHomePhabricator

jquery.ui.core styles overriding Wikibase styles for references-heading toggle
Closed, ResolvedPublic

Description

On wikidata, jquery.ui.core styles are overriding the wikibase styles for the references-heading toggle.

this means it's styled blue with an outline, whereas we normally override and remove these styles.

in the html header, I see:

<link rel="stylesheet" href="bits.wikimedia.org/www.wikidata.org/load.php?debug=false&amp;lang=en&amp;modules=ext.echo.badge%7Cext.uls.nojs%7Cext.wikihiero%7Cjquery.wikibase.statementview%2Ctoolbar%7Cmediawiki.legacy.commonPrint%2Cshared%7Cmediawiki.skinning.interface%7Cmediawiki.ui.button%7Cskins.vector.styles%7Cwikibase.common%2Ctoc&amp;only=styles&amp;skin=vector&amp;*">
<link rel="stylesheet" href="
bits.wikimedia.org/www.wikidata.org/load.php?debug=false&amp;lang=en&amp;modules=jquery.ui.core&amp;only=styles&amp;skin=vector&amp;*">

with jquery.ui.core being added after jquery.wikibase.statementview. (I see these are added by EntityView?)

with debug=true, it works correctly, but simply (it seems!) because each of the above is loaded individually in alphabetical order, so jquery comes before wikibase.

I cannot reproduce the issue on my dev wiki, although have occasionally seen this happen before and never found out why.


Version: unspecified
Severity: normal

Details

Reference
bz70327

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:43 AM
bzimport set Reference to bz70327.
bzimport added a subscriber: Unknown Object (MLST).

I remember seeing this. Purging always fixed it.

Currently I can't reproduce it. Do you have an example URL?