Page MenuHomePhabricator

BetaFeatures: Some beta features are incorrectly reporting javascript is need (when it is already enabled)
Closed, ResolvedPublic

Description

This feature requires JavaScript. is shown on beta features.

On browsers which have Javascript enabled, some beta features are showing that "This feature requires JavaScript." even when Javascript is enabled. Features seem to work even though the error is shown.


Version: master
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=69823
https://bugzilla.wikimedia.org/show_bug.cgi?id=69779

Attached:

Screenshot_2014-09-03_16.51.30.png (1×1 px, 229 KB)

Details

Reference
bz70371

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:46 AM
bzimport added a project: BetaFeatures.
bzimport set Reference to bz70371.

Can't quite work out what's going wrong here, so am putting in a bodge that fixes it at higher cost…

gerritadmin wrote:

Change 159098 had a related patch set uploaded by Jforrester:
Hide the 'JavaScript needed' warning reliably

https://gerrit.wikimedia.org/r/159098

That will probably workaround it, but the underlying problem seemed to be bug 69823.

This bug is a consequence of bug 69823 (which is itself a consequence of bug 70814), see https://bugzilla.wikimedia.org/show_bug.cgi?id=70814#c5 : the fix there correctly hides the JS warning when JS is enabled. (I make this bug depend of bug 70814, but it is similar to a duplicate.)

Independently of the other bug, I guess this fix is probably worth to be merged also.

gerritadmin wrote:

Change 159098 abandoned by Bartosz Dziewoński:
Hide the 'JavaScript needed' warning reliably

Reason:
Superseded by https://gerrit.wikimedia.org/r/159538 and https://gerrit.wikimedia.org/r/161690

https://gerrit.wikimedia.org/r/159098