Page MenuHomePhabricator

OOjs UI: [Regression wmf20] Popups sizing broken
Closed, ResolvedPublic

Description

Screenshot

Open a new page with VE for the first time which has not yet been created.
Observe the notification dialog box.

See the screenshot attached


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=70601
https://bugzilla.wikimedia.org/show_bug.cgi?id=70604

Attached:

Screen_Shot_2014-09-04_at_4.33.18_PM.png (573×1 px, 124 KB)

Details

Reference
bz70423

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:50 AM
bzimport added a project: OOUI.
bzimport set Reference to bz70423.

Created attachment 16379
betalabs screenshot

Attached:

Screen_Shot_2014-09-04_at_4.34.55_PM.png (743×1 px, 158 KB)

Seems to have been caused by Gerrit change 157295

In particular, this bit:

"Bonus:
ClippableElement.js

  • The toggleClipping method had an undocumented and unneeded async behavior for calling clip the first time after toggling clipping
    • This has been removed and calling code has been verified to not be affected
    • A comment has been added to inform callers that the element needs to be attached and visible before toggling clipping, which is supposedly what the setTimeout was in aid of, but no longer seems to be needed for"

gerritadmin wrote:

Change 159062 had a related patch set uploaded by Alex Monk:
PopupWidget: Toggle clipping -after- updating dimensions

https://gerrit.wikimedia.org/r/159062

  • Bug 70565 has been marked as a duplicate of this bug. ***

Adding my screenshot taken in IE.

Created attachment 16411
Attempting to create a page on mediawiki.org

Attached:

Warnings_in_IE-VE.png (922×1 px, 70 KB)

Created attachment 16417
screenshot of tooltip dialogs

There are few other places where notification dialogs are appearing in not so properly styled way.For example: the help tooltip dialogs inside Page Settings option or Template dialog. If they dont get fixed by this patch , I will file a separate bug.For now, keeping it all in this one, to keep track.

Attached:

Screen_Shot_2014-09-09_at_11.16.42_AM.png (455×715 px, 52 KB)

  • Bug 70604 has been marked as a duplicate of this bug. ***

gerritadmin wrote:

Change 159062 merged by jenkins-bot:
PopupWidget: Toggle clipping -after- updating dimensions

https://gerrit.wikimedia.org/r/159062

gerritadmin wrote:

Change 159508 had a related patch set uploaded by Catrope:
PopupWidget: Toggle clipping -after- updating dimensions

https://gerrit.wikimedia.org/r/159508

gerritadmin wrote:

Change 159508 merged by Catrope:
PopupWidget: Toggle clipping -after- updating dimensions

https://gerrit.wikimedia.org/r/159508

verified the fix in Betalabs,separate bug has been filed for the help tooltips for Page Settings menu.

Backport did not work in test2 , the notification dialog and the context dialogs for template fields are still broken there.

It's working for me... Can you try it without any caching, etc.? Maybe in incognito mode?