Page MenuHomePhabricator
Create Task
Maniphest T72497

Flow: Comparisons of deleted content when viewed by non-admins leads to fatal permissionexception message
Open, HighPublic
Actions

Description

If a non-admin visits a deleted topic
they receive this error message:

Insufficient permission to access the content.
Return to Main Page.
[6138f9cc] 2014-09-06 19:39:49: Fatal exception of type Flow\Exception\PermissionException

There should be a more informative message for readers, so that they can understand what happened. The standard is a message like this: https://en.wikipedia.org/w/index.php?title=Talk:Gabriel_de_Saint_Nicholas&redirect=no

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=62176

Details

Reference
bz70497

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:54 AM
• bzimport added a project: StructuredDiscussions.
• bzimport set Reference to bz70497.
• bzimport added a subscriber: Unknown Object (MLST).
Quiddity created this task.Sep 6 2014, 8:03 PM
Quiddity added a comment.Sep 6 2014, 8:05 PM

On trello at https://trello.com/c/QaqSXXyF/

matmarex added a comment.Sep 9 2014, 3:05 PM
  • Bug 70598 has been marked as a duplicate of this bug. ***
Quiddity added a comment.Sep 11 2014, 3:35 AM

Copying comment from 70598:

(Marius Hoch wrote)

Trace:

2014-09-09 11:08:15 mw1052 mediawikiwiki: [e4cd902c]
/w/index.php?title=Topic:S1no6gacx8ayjfuo&workflow=s1no6gacx8ayjfuo
Exception from line 438 of
/usr/local/apache/common-local/php-1.24wmf20/extensions/Flow/includes/Block/
Topic.php: Not Allowed
#0
/usr/local/apache/common-local/php-1.24wmf20/extensions/Flow/includes/View.
php(129): Flow\Block\TopicBlock->renderAPI(Object(Flow\Templating), Array)
#1
/usr/local/apache/common-local/php-1.24wmf20/extensions/Flow/includes/
Actions/Action.php(88): Flow\View->show(Object(Flow\WorkflowLoader), 'view')
#2
/usr/local/apache/common-local/php-1.24wmf20/extensions/Flow/includes/
Actions/Action.php(35): Flow\Actions\FlowAction->showForAction('view')
#3 /usr/local/apache/common-local/php-1.24wmf20/includes/MediaWiki.php(414):
Flow\Actions\FlowAction->show()
#4 /usr/local/apache/common-local/php-1.24wmf20/includes/MediaWiki.php(282):
MediaWiki->performAction(Object(Article), Object(Title))
#5 /usr/local/apache/common-local/php-1.24wmf20/includes/MediaWiki.php(584):
MediaWiki->performRequest()
#6 /usr/local/apache/common-local/php-1.24wmf20/includes/MediaWiki.php(435):
MediaWiki->main()
#7 /usr/local/apache/common-local/php-1.24wmf20/index.php(46):
MediaWiki->run()
#8 /usr/local/apache/common-local/w/index.php(3):
require('/usr/local/apac...')

Copying comment from 70692:

(Daniel Zahn wrote)

on a https://en.wikipedia.org/wiki/Topic:S23kgr0jal6zroqo

i get this:

---<snip>---

Error

Insufficient permission to access the content.

Return to Main Page.
[d9c5180c] 2014-09-10 23:06:33: Fatal exception of type
Flow\Exception\PermissionException

---</snip>---

it's not about the "insufficient permission" part, that is legit,
but the fatal exception that comes with it.

Quiddity added a comment.Sep 11 2014, 3:36 AM
  • Bug 70692 has been marked as a duplicate of this bug. ***
Quiddity added a comment.Sep 25 2014, 1:37 AM
  • Bug 71244 has been marked as a duplicate of this bug. ***
He7d3r added a comment.Sep 26 2014, 8:16 PM

I assume this is the same problem:
https://www.mediawiki.org/w/index.php?title=Topic:S2tc6rvtyh4qlwcs&workflow=s2tc6rvtyh4qlwcs
[95d66b59] 2014-09-26 20:15:15: Fatal exception of type Flow\Exception\PermissionException

gerritbot added a comment.Oct 14 2014, 2:40 PM

Change 166574 had a related patch set uploaded by Matthias Mullie:
(bug 70497) Don't throw exception; show nicer error message for insufficient permissions

https://gerrit.wikimedia.org/r/166574

gerritbot added a comment.Oct 14 2014, 2:40 PM

Change 166575 had a related patch set uploaded by Matthias Mullie:
(bug 70497) Show more descriptive error message for insufficient permissions

https://gerrit.wikimedia.org/r/166575

gerritbot added a comment.Oct 24 2014, 2:13 AM

Change 166574 merged by jenkins-bot:
(bug 70497) Don't throw exception; show nicer error message for insufficient permissions

https://gerrit.wikimedia.org/r/166574

gerritbot added a comment.Oct 24 2014, 10:57 PM

Change 166575 had a related patch set uploaded by Siebrand:
Show more descriptive error message for insufficient permissions

https://gerrit.wikimedia.org/r/166575

gerritbot added a comment.Nov 3 2014, 6:31 PM

Change 166575 merged by jenkins-bot:
Show more descriptive error message for insufficient permissions

https://gerrit.wikimedia.org/r/166575

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:32 AM
He7d3r reopened this task as Open.Mar 31 2015, 11:09 AM

This is happening again:
https://www.mediawiki.org/w/index.php?title=Topic:Sdoatsbslsafx6lw&action=compare-post-revisions&topic_newRevision=sek25j6516xg0rv0

[5ec79ae0] 2015-03-31 11:07:18: Fatal exception of type "Flow\Exception\PermissionException"

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 31 2015, 11:09 AM
EBernhardson triaged this task as High priority.Mar 31 2015, 5:47 PM
• Spage unsubscribed.Apr 6 2015, 8:35 PM
EBernhardson unsubscribed.Jul 18 2018, 6:56 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 18 2018, 6:56 PM
SBisson moved this task from Inbox to Triaged but Future on the Growth-Team board.Jul 20 2018, 5:58 PM
Dzahn unsubscribed.Jul 24 2018, 11:43 PM
Pppery updated the task description. (Show Details)May 23 2019, 9:12 PM
Pppery subscribed.

<removing link to topic on enwiki; the flow extension has since been uninstalled>

Pppery unsubscribed.May 23 2019, 9:13 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 7:05 PM
Aklapper removed a project: Collaboration-Team-Triage.May 25 2021, 9:09 PM
Pppery closed this task as Resolved.Jan 29 2023, 5:10 PM
This comment was removed by Pppery.
Pppery renamed this task from Flow: Deleted content when viewed by non-admins leads to fatal permissionexception message to Flow: Comparisons of deleted content when viewed by non-admins leads to fatal permissionexception message.Jan 29 2023, 5:11 PM
Pppery reopened this task as Open.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL