Page MenuHomePhabricator

VisualEditor: [Regression pre-wmf21] Checking "Border" in media settings dialog is not enabling "Apply changes" button
Closed, ResolvedPublic

Description

Steps to reproduce:

1.Open a page with VE
2.Open Media Settings dialog for a Frameless/Basic type image which does not have "Border" set to it.
3.Now check the "Border" checkbox

Observed Result:
It does not enable the "Apply Changes" button in the media Settings dialog

Environment:Betalabs


Version: unspecified
Severity: minor

Details

Reference
bz70575

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:43 AM
bzimport set Reference to bz70575.

This is due to an OOjs bug.

OO.compare( { foo: 3 }, { foo: 4 } )

false

OO.compare( { foo: false }, { foo: true } )

true

Because we have special cases for 'number' and 'string' but not 'boolean'.

Released in OOjs 1.1.1, now in MW-core etc.

Verified the fix in production