Page MenuHomePhabricator

wikitech strict warnings on API save
Closed, ResolvedPublic

Description

morebots-patch-wikitech-strict-warning-2014-09-04.patch

+++ This bug was initially created as a clone of Bug #70436 +++

morebots !log to wikitech broke during the upgrade.

API response looks like this:
{"edit":{"result":"Success","pageid":7919,"title":"Server Admin Log","contentmodel":"wikitext","oldrevid":126205,"newrevid":126208,"newtimestamp":"2014-09-09T19:05:40Z"}}<br />
<b>Strict Standards</b>: Declaration of LuceneResult::getTitleSnippet() should be compatible with that of SearchResult::getTitleSnippet() in <b>/usr/local/apache/common-local/php-1.24wmf15/extensions/MWSearch/MWSearch_body.php</b> on line <b>153</b><br />
(208.80.154.18)

and so morebots says that's not valid JSON (extra data on the end).

morebots patch attached


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=70436

Attached:

Details

Reference
bz70628

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:47 AM
bzimport set Reference to bz70628.
bzimport added a subscriber: Unknown Object (MLST).

(I'm pretty sure this is the same issue, but am not confident.)

There is a fix in place now that should resolve those warnings, cherry-picked to the wikitech branch. Can you please verify if this is correct and, if so, de-hack the bot so it's back to running the standard debian version? Thx

Krenair claimed this task.
Krenair subscribed.

I think this would've been fixed ages ago (by https://gerrit.wikimedia.org/r/#/c/183069/ ? or the wikitech config changes)