Page MenuHomePhabricator

VisualEditor: [Regression wmf21] Editor is displayed with two toolbars on second initialisation
Closed, ResolvedPublic

Description

double Toolbars in VE

Environment- Test2, beta

1> switch from Edit beta mode to Read mode notice the toolbar has slide down and is still visible in the Read mode.

2> Click on Edit beta again,the Editor is displayed with two toolbars.See screenshot.


Version: unspecified
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=70770
https://bugzilla.wikimedia.org/show_bug.cgi?id=70782

Attached:

s.png (549×1 px, 81 KB)

Details

Reference
bz70768

Event Timeline

Browsers- FF and Chrome. Couldn't test on Safari.

I can't reproduce this. Does this also happen when you're logged out?

(In reply to Roan Kattouw from comment #2)

I can't reproduce this. Does this also happen when you're logged out?

I can reproduce it(tried with a clear cache). Yes, it happens even when i am logged out.

Ritu, can you share the link to the page where you are getting this, I can't reproduce it either.

(In reply to Rummana Yasmeen from comment #4)

Ritu, can you share the link to the page where you are getting this, I can't
reproduce it either.

links-:
https://test2.wikipedia.org/wiki/User:Swainr?veaction=edit

http://en.wikipedia.beta.wmflabs.org/wiki/User:Swainr?veaction=edit

Created attachment 16454
Screenshot

Ok, so I reproduced it on my user page too.This is happening when you just have the following on your page:

NEWSECTIONLINK__NOTOC__

Attached:

Screen_Shot_2014-09-12_at_2.28.14_PM.png (467×1 px, 99 KB)

This issue is reappearing.

Steps-
1> in a blank page insert a Reflist or Notelist Template.
2> Save the page and reopen it in VE mode.
3> Now cilck on the Read tab.
4> Repeat steps #2 and #3. Toolbars are getting added.

I cannot reproduce it following your steps.In steps 4, you mentioned to repeat step 2, what change have you done in the page for the second time to save it?

(In reply to Rummana Yasmeen from comment #11)

I cannot reproduce it following your steps.In steps 4, you mentioned to
repeat step 2, what change have you done in the page for the second time to
save it?

http://youtu.be/CNqxmnconN8

Ok thanks so much Ritu! I can now reproduce it.The following error appears in the console as well:
Uncaught TypeError: Cannot read property 'height' of null

gerritadmin wrote:

Change 162359 had a related patch set uploaded by Catrope:
Tolerate null boundingRect in all code paths in DesktopContext#updateDimensions

https://gerrit.wikimedia.org/r/162359

gerritadmin wrote:

Change 162360 had a related patch set uploaded by Catrope:
Don't drop 1px rects for FocusableNodes if all we have is 1px rects

https://gerrit.wikimedia.org/r/162360

gerritadmin wrote:

Change 162359 merged by jenkins-bot:
Tolerate null boundingRect in all code paths in DesktopContext#updateDimensions

https://gerrit.wikimedia.org/r/162359

gerritadmin wrote:

Change 162360 merged by jenkins-bot:
Don't drop 1px rects for FocusableNodes if all we have is 1px rects

https://gerrit.wikimedia.org/r/162360

gerritadmin wrote:

Change 162497 had a related patch set uploaded by Catrope:
Don't drop 1px rects for FocusableNodes if all we have is 1px rects

https://gerrit.wikimedia.org/r/162497

gerritadmin wrote:

Change 162497 merged by Catrope:
Don't drop 1px rects for FocusableNodes if all we have is 1px rects

https://gerrit.wikimedia.org/r/162497

verified the backport in test2

Verified the fix in production