Page MenuHomePhabricator
Create Task
Maniphest T72777

VisualEditor: [Regression wmf21] Inserting multi-node template (?) causes endless snowmen
Closed, ResolvedPublic
Actions

Description

Initial case:

  1. Go to https://www.mediawiki.org/wiki/VisualEditor/status?veaction=edit.
  2. Scroll to the final section, remove the "…", and insert template.
  3. Pick "key press" in the normal way.
  4. Set parameter 1 as "Ctrl", parameter 2 as "Shift", and parameter 3 as "V".
  5. Press "Insert".

Result: dialog remains pending whilst endless snowmen get inserted.

Version: unspecified
Severity: major
URL: https://www.mediawiki.org/w/index.php?title=VisualEditor/status&oldid=1152478

Details

Reference
bz70777

Event Timeline

• bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:56 AM
• bzimport added projects: VE-deploy-2014-09-18, VisualEditor-EditingTools.
• bzimport set Reference to bz70777.
Jdforrester-WMF created this task.Sep 12 2014, 6:19 PM
gerritbot added a comment.Sep 12 2014, 9:57 PM

Change 160102 had a related patch set uploaded by Catrope:
Account for the case where a FocusableNode has an empty outerRects array

https://gerrit.wikimedia.org/r/160102

gerritbot added a comment.Sep 12 2014, 10:00 PM

Change 160102 merged by jenkins-bot:
Account for the case where a FocusableNode has an empty outerRects array

https://gerrit.wikimedia.org/r/160102

gerritbot added a comment.Sep 12 2014, 10:01 PM

Change 160105 had a related patch set uploaded by Jforrester:
Account for the case where a FocusableNode has an empty outerRects array

https://gerrit.wikimedia.org/r/160105

gerritbot added a comment.Sep 12 2014, 10:07 PM

Change 160105 merged by jenkins-bot:
Account for the case where a FocusableNode has an empty outerRects array

https://gerrit.wikimedia.org/r/160105

Ryasmeen added a comment.Sep 15 2014, 11:58 PM

Verified the fix in mediawiki.org with the case mentioned above.

Jdforrester-WMF added a project: VisualEditor.Nov 27 2014, 12:46 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL