Page MenuHomePhabricator
Create Task
Maniphest T72806

sk id gets truncated
Closed, ResolvedPublic
Actions

Description

See https://git.wikimedia.org/blob/labs%2Ftools%2Fheritage.git/5c085eee5cf6c8d04868f416afbf12d9e6abcab2/erfgoedbot%2Fmonuments_config.py#L7418 code

It's set to varchar(11), but the id's might be longer so 101-10006/18 gets truncated into 101-10006/1 causing all sorts of weird problems. Needs to be fixed in German too. Raising it to 15 and generating the two tables should fix it.

Version: unspecified
Severity: normal

Details

Reference
bz70806

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:58 AM
• bzimport added a project: Wiki-Loves-Monuments-Database.
• bzimport set Reference to bz70806.
Multichill created this task.Sep 13 2014, 9:49 AM
gerritbot added a comment.Sep 20 2014, 3:52 PM

Change 161672 had a related patch set uploaded by Multichill:
(bug 70806): Fix id length for sk so it wont get truncated

https://gerrit.wikimedia.org/r/161672

gerritbot added a comment.Sep 20 2014, 3:53 PM

Change 161672 merged by Multichill:
(bug 70806): Fix id length for sk so it wont get truncated

https://gerrit.wikimedia.org/r/161672

Multichill added a comment.Sep 20 2014, 3:56 PM

Fixed and deployed

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL