Description
Details
- Reference
- bz70836
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Umherirrender | T26156 Messages of log entries should support GENDER | |||
| Resolved | None | T23716 Log entries assume sentence starts with username | |||
| Open | None | T26620 Log entries are difficult to localize; convert old style logs to the new code | |||
| Resolved | matej_suchanek | T72836 GENDER support needed for usermerge-userdeleted-log and usermerge-move-log |
Event Timeline
gerritadmin wrote:
Change 161032 had a related patch set uploaded by 01tonythomas:
Added GENDER suport for log messages
Change 161032 had a related patch set uploaded (by Paladox):
Added GENDER suport for log messages.
[Resetting task assignee to avoid cookie-licking. Please reclaim the task when you plan to actively work on this task. Thanks!]
Seems like this needs some work. From what I can tell, some of the log messages currently use GENDER even though it's not supported. Seems like it will need to be converted to the new logging system. I'm not sure how that will go, as some of the log messages are actually created in certain files, e.g. usermerge-move-log is created in usermerge.php, so not sure how that conversion will be. Also, I'm not sure how to preserve the parameters. https://github.com/wikimedia/mediawiki/blob/0e1c391d97418e646a58d6f6f2545a83271b07ff/includes/logging/LogFormatter.php#L501-L509 uses 1 2 and 3 as those defaults. Does that mean checking for each messages and adding a parameter or something? This is a rough outline, imo, of what needs to be done, but will need some feedback from others before I begin to try to implement it. I will look into it, and will hopefully will be able to take a stab at this. Any comments are appreciated.
Thanks,
MtDu
Change 461292 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/UserMerge@master] Migrate UserMerge to modern logging system
Change 461292 merged by jenkins-bot:
[mediawiki/extensions/UserMerge@master] Migrate UserMerge to modern logging system
Change 161032 abandoned by Matěj Suchánek:
Added GENDER suport for log messages.
Reason:
Already done.
Change 484025 had a related patch set uploaded (by Paladox; owner: Matěj Suchánek):
[mediawiki/extensions/UserMerge@REL1_32] Migrate UserMerge to modern logging system
Change 484025 merged by jenkins-bot:
[mediawiki/extensions/UserMerge@REL1_32] Migrate UserMerge to modern logging system