Page MenuHomePhabricator

Default timezone always UTC when using HHVM despite settings in config
Closed, ResolvedPublic

Description

Currently we have just under 200 wikis using 'non standard' default time zones (set in http://noc.wikimedia.org/conf/InitialiseSettings.php.txt ) where the default time zone is something other then UTC. That default time zone is used (unless it's changed in the preferences) for all interface timestamp displays (such as recent changes, user contributions or page histories). It is also used (whether you change your preferences or not) for the time stamp in an onwiki signature.

When you enable the HHVM beta feature on one of these wikis the time zone is defaulted to UTC regardless of the setting in InitialiseSettings. This then shows the UTC times in the interface displays. It does NOT appear to change the time zone used for signatures.

Duplication steps to see:

  1. Go to a wiki with a non standard default time zone (example: sv.wikipedia.org or http://noc.wikimedia.org/conf/InitialiseSettings.php.txt)
  1. Go to the beta features page (example: https://sv.wikipedia.org/wiki/Special:Preferences#mw-prefsection-betafeatures ) and make sure you do not have HHVM enabled.
  1. Go to you appearance preferences (example: https://sv.wikipedia.org/wiki/Special:Preferences#mw-prefsection-rendering ) and ensure you are on the 'use wiki default' time zone. If you are not switch to it. [you can see here that the default shows in parens the time zone used such as 'Europe/Berlin']
  1. Go to (or open in a new tab) a page showing interface time stamps such as contributions (example: https://sv.wikipedia.org/wiki/Special:Contributions/Jalexander-WMF ) [you can see the time stamps in the local wiki default]
  1. Go back to beta features page, check HHVM and save.
  1. Go back to (or refresh) the page showing interface time stamps. [you will see them changed, now displayed in UTC]
  1. You can also view the appearance preferences page again. [you will see the 'use wiki default' now shows +00:00 as the time zone]
  1. You can go back to the beta features page, uncheck HHVM and save. [all previous pages will revert back to the original wiki default.]

It does NOT appear that signature time stamps change (they are still in the wiki default as defined in the wiki config settings)


Version: unspecified
Severity: normal

Details

Reference
bz71036

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:55 AM
bzimport set Reference to bz71036.
bzimport added a subscriber: Unknown Object (MLST).

gerritadmin wrote:

Change 161439 had a related patch set uploaded by Ori.livneh:
Don't manipulate the environment to determine TZ offset

https://gerrit.wikimedia.org/r/161439

gerritadmin wrote:

Change 161439 merged by jenkins-bot:
Don't manipulate the environment to determine TZ offset

https://gerrit.wikimedia.org/r/161439

James: thanks a ton for the excellent bug report. I pushed out a fix just now and I think the problem is gone. Can you confirm?

(In reply to Ori Livneh from comment #3)

James: thanks a ton for the excellent bug report. I pushed out a fix just
now and I think the problem is gone. Can you confirm?

Aye, I have not been able to replicate it anymore after checking out a couple wikis so looks like it's set! Thank you for the speedy fix!