Page MenuHomePhabricator

VisualEditor: [Regression wmf1] Link inspector does not close when clicking out into non-linked text
Closed, ResolvedPublic

Description

  1. Open VisualEditor
  2. Find or create a paragraph with a link followed by some non-linked text
  3. Inspect the link
  4. While the link inspector is open, click to drop the cursor in the non-linked text

The link inspector does not close, and instead moves to follow your selection.


Version: unspecified
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=71151

Details

Reference
bz71373

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:44 AM
bzimport set Reference to bz71373.

This broke in https://gerrit.wikimedia.org/r/#/c/162495/ , which made it so contextChange is no longer emitted when the selection moves from inside a link to outside a link.

(In reply to Bartosz Dziewoński from comment #2)

Related? Bug 71151.

Yes, absolutely. While investigating this, I wished I had "git bisect concerning" in addition to "good" and "bad". At first, nothing was wrong, then the flicker started happening, and now it doesn't close at all.

I think this happened because Ed changed the context to reposition itself directly from events emitted by the surface. The surface also emits a contextChange event that causes the context to realize that it should close (or did; this bug is about that event not being emitted any more), but that event listener is debounced, so we close the context after moving it.

Change 163783 had a related patch set uploaded by Catrope:
Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's

https://gerrit.wikimedia.org/r/163783

Change 163783 merged by jenkins-bot:
Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's

https://gerrit.wikimedia.org/r/163783

Change 163852 had a related patch set uploaded by Jforrester:
Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's

https://gerrit.wikimedia.org/r/163852

Change 163852 merged by jenkins-bot:
Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's

https://gerrit.wikimedia.org/r/163852

Merged into master and deployed to wmf1.

Verified the fix in test2 and production