For the MediaWiki 1.23.4 release, a patch file was provided that was based on all files in Git, instead of just the files we provide in a tarball. As a result, the audience the patch is intended for (using tarball instead of Git), could not apply it cleanly without warnings.
Description
Details
- Reference
- bz71379
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Move to `git archive` like model for MediaWiki releases | mediawiki/tools/release | master | +225 -4 |
Related Objects
- Duplicates Merged Here
- T181116: MediaWiki release patch files should be based off of the previous tarball
Event Timeline
The problem is that you installed 1.23.3 from a tarball, but the patch is based on an installation from Git. Files for testing purposes aren't included in the tarball, but the patch tried to change one of them, which is why it couldn't find it. Your upgrade was successful even though you skipped that file.
Not sure if still this is still an issue with current processes. In case it's still an issue, tagging for next release. Seems easy to fix :)
I think the ideal long term fix is to generate the patch files by diffing the two tarballs instead of trying to use git diffs.
Are patches even useful these days when download speed is much less of a problem than 20 years ago?
Change 454609 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/tools/release@master] Move to git archive like model for MediaWiki releases
Change 454609 merged by jenkins-bot:
[mediawiki/tools/release@master] Move to git archive like model for MediaWiki releases