Page MenuHomePhabricator

Some test runs are verbose
Closed, ResolvedPublic

Description

Some test runs become verbose, without a user config setting for verbosity. This previously occurred for travis builds against ar.wikipedia.

https://travis-ci.org/wikimedia/pywikibot-core/jobs/34230160

Current travis builds do not exhibit this behaviour, however it still occurs on my ar.wikipedia test runs.


Version: core-(2.0)
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=71864

Details

Reference
bz71454

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:49 AM
bzimport set Reference to bz71454.
bzimport added a subscriber: Unknown Object (????).

The cause of the problem appears to be flickrapi 1.4.4 which calls logging.basicConfig(), which is not appropriate for a library.

https://bitbucket.org/sybren/flickrapi/src/e91ab5c64c7ed036a7397474ec31f9b16d3e62a9/flickrapi/__init__.py?at=branch-1.4#cl-68

The bug stopped happening on travis because script_tests first checks for ImageTk, which fails for travis builds, so flickrapi isnt loaded

https://travis-ci.org/wikimedia/pywikibot-core/jobs/37419168

"flickrripper depends on ImageTk, which isnt available:
No module named ImageTk"

Now that we've fixed all the other issues with flickrripper, this is now causing builds to fail.

Some options:

  1. use a custom build of flickrapi 1.4.4 for tests
  2. use the hg master build of flickrapi for tests
  3. somehow detect what flickrapi 1.4.4 has done and undo it

The simplest fix is option 2

Change 171479 had a related patch set uploaded by John Vandenberg:
Use flickrapi master for tests

https://gerrit.wikimedia.org/r/171479

Change 171491 had a related patch set uploaded by John Vandenberg:
Use custom flickrapi 1.4

https://gerrit.wikimedia.org/r/171491

jayvdb claimed this task.