Page MenuHomePhabricator

VisualEditor: [Regression wmf2] Deleting any focusable node throws "error:NS_ERROR_FAILURE:" in Firefox and wrong context menu starts appearing for other nodes
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Select any focusable node: citation note,math ,template or image

Observed Result:

The following error appears in the console:
NS_ERROR_FAILURE:

The context menu for that focusable note is still active in CE ,if you select some other focusable note after this, no context menu appears for it or the one for previous node appears on top of it

Environment:test2 and Betalabs


Version: unspecified
Severity: major

Attached:

Screen_Shot_2014-10-02_at_4.02.36_PM.png (617×954 px, 97 KB)

Details

Reference
bz71580

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:58 AM
bzimport set Reference to bz71580.

Reproducible in standalone with comment nodes too.

Caused by 0d7eaf51767c4061b478610a035a3bc387c0973a (workaround for bug 70724 about broken Firefox cursoring). Calling .collapseToStart() sometimes fixes the selection, and sometimes causes this cryptic exception.

This looks very ugly and very internal, so I'm just going to revert the patch and update the upstream bug report.

Change 164548 had a related patch set uploaded by Bartosz Dziewoński:
Revert "ve.ce.Surface: Magic workaround for broken Firefox cursoring"

https://gerrit.wikimedia.org/r/164548

Change 164593 had a related patch set uploaded by Jforrester:
Revert "ve.ce.Surface: Magic workaround for broken Firefox cursoring"

https://gerrit.wikimedia.org/r/164593

Change 164548 merged by jenkins-bot:
Revert "ve.ce.Surface: Magic workaround for broken Firefox cursoring"

https://gerrit.wikimedia.org/r/164548

Change 164593 merged by jenkins-bot:
Revert "ve.ce.Surface: Magic workaround for broken Firefox cursoring"

https://gerrit.wikimedia.org/r/164593

Verified the backport in test2