Page MenuHomePhabricator

Flow: topic page can get stuck in collapsed or small view, can't expand
Closed, ResolvedPublic

Description

  1. View a Flow board
  2. Switch to small view.
  3. From the action menu of one of the topics choose Permalink

Result: the Topic:<UUID> page shows the topic titlebar only in small view. There's no way to show the topic comments from the page.

The workaround is you have to know to go back to the Flow board, click the collapser tri-state back to Topics and posts view, then reload the topic. Uggh.

Expected behavior: *NONE* of topic collapse state and collapser preference and topic collapse mode should affect the display of an individual topic. You always see an individual topic expanded. Maybe this means we can remove some storer code and view topic logic.

This is tracked in https://trello.com/c/NdRgfEAO/577-h-99-topic-pages-show-uncollapsed-released-fix-has-another-bug


Version: master
Severity: major

Details

Reference
bz71593

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:59 AM
bzimport set Reference to bz71593.
bzimport added a subscriber: Unknown Object (MLST).

I see the entire topic with comments appear, then it gets shrunk down. We could fiddle with CSS so that classes like .flow-board-collapsed-compact don't make things hidden, but we should also just not run the collapser code when viewing a single topic.

Change 165015 had a related patch set uploaded by Spage:
Prevent board-level collapsing classes from being applied on non-board pages like topic view

https://gerrit.wikimedia.org/r/165015

Change 165015 abandoned by SG:
Prevent board-level collapsing classes from being applied on non-board pages like topic view

Reason:
Change is incorporated in big "Implement OOJS on Flow JS patches" patch Iec45fd1e17

https://gerrit.wikimedia.org/r/165015

Mattflaschen-WMF claimed this task.

Seems to be fixed. Also, we're removing collapse functionality as part of the TOC work.