replace.py: async output messages jumbled with user interaction on main thread
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	JAnD
	Oct 4 2014, 8:36 PM

Description

when running replace.py with manual confirming of each replace, bot have often some pages in save queue. In compat all messages about saving appeared after confirming some of next

>>>Page 1<<<
- FOO
+ BAR
Do you fant to accept... [y/n]y
Page [[Lorem]] saved
Page [[Ipsum]]saved

In core these messages sometimes appears before confirming 

No changes were necessary in [[Ivan Král vydá po dvanácti letech nové album]]
Page [[Izrael popřel, že by střílel na vozidlo OSN]] saved

>>> Je zvažováno obnovení meziměstské tramvaje mezi Bratislavou a Vídní <<<
-  | odkaz na periodikum = IDnes
+  | odkaz na periodikum = IDNES.cz

Do you want to accept these changes? ([y]es, [N]o, [e]dit, open in [b]rowser, [a
]ll, [q]uit) Page [[Italka odpojená po letech od vyživovacích přístrojů zemřela]
] saved
y

Version: core-(2.0)
Severity: normal

Details

Reference: bz71646

Subject	Repo	Branch	Lines +/-
[IMPR] Re-enable cached output functionality from compat	pywikibot/core	master	+103 -62
[bugfix] Port cache_output from compat	pywikibot/core	master	+314 -144
Control output message when saving.	pywikibot/core	master	+39 -10

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Invalid	None	T72936 Important tasks to be solved (tracking)
Open	None	T151110 RFC: Regressions of core should be rethought or solved
Resolved	Xqt	T196039 replace.py async does not seem to be async at all
Resolved	Xqt	T73646 replace.py: async output messages jumbled with user interaction on main thread
Resolved	Xqt	T151727 Port cache_output from compat

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:45 AM

• bzimport added a project: Pywikibot-Scripts.

• bzimport set Reference to bz71646.

• bzimport added a subscriber: Unknown Object (????).

JAnD created this task.Oct 4 2014, 8:36 PM

Aklapper added a project: Pywikibot.Nov 27 2014, 4:12 PM

jayvdb changed the task status from Open to Stalled.Jun 9 2015, 5:57 AM

jayvdb triaged this task as Medium priority.

jayvdb updated the task description. (Show Details)

jayvdb edited projects, added Pywikibot-replace.py; removed Pywikibot-Scripts.

jayvdb set Security to None.

Mpaa subscribed.Oct 23 2015, 9:33 PM

Change 248680 had a related patch set uploaded (by Mpaa):
Control output message when saving in async mode

https://gerrit.wikimedia.org/r/248680

gerritbot added a project: Patch-For-Review.Oct 25 2015, 10:12 AM

Mpaa changed the task status from Stalled to Open.Oct 25 2015, 10:14 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 25 2015, 10:14 AM

Change 248680 merged by jenkins-bot:
Control output message when saving.

https://gerrit.wikimedia.org/r/248680

jayvdb closed this task as Resolved.Nov 10 2015, 6:26 AM

jayvdb assigned this task to Mpaa.

jayvdb mentioned this in T121948: Pywikibot 2.0rc5.Jan 19 2016, 7:06 AM

Xqt mentioned this in T132135: template.py does not show when a page is saved.Apr 11 2016, 2:53 PM

Reopened. I think the current implementation is not very usefull because that problem not only occurs on replace.py and subclasses of that bot but all scripts putting asynchroneous have this problem. This is core-specific and does not occur in compat because there is a cache_output implemented when any input aquires input_lock. Refer # User output/logging functions in wikipedia.py.

Xqt added a parent task: T132135: template.py does not show when a page is saved.Apr 11 2016, 6:58 PM

Change 282818 had a related patch set uploaded (by Xqt):
[bugfix] Port cache_output from compat

https://gerrit.wikimedia.org/r/282818

gerritbot added a project: Patch-For-Review.Apr 11 2016, 9:58 PM

Xqt added a parent task: T151110: RFC: Regressions of core should be rethought or solved.Nov 24 2016, 10:32 AM

Xqt added a parent task: T151727: Port cache_output from compat.Nov 27 2016, 5:42 PM

Xqt removed a parent task: T151727: Port cache_output from compat.Nov 27 2016, 5:47 PM

Xqt added a subtask: T151727: Port cache_output from compat.

Xqt raised the priority of this task from Medium to High.May 28 2017, 11:55 AM

Dvorapa subscribed.Jun 10 2017, 3:56 PM

Dvorapa mentioned this in T196039: replace.py async does not seem to be async at all.May 31 2018, 6:01 AM

Dvorapa added a parent task: T196039: replace.py async does not seem to be async at all.