Page MenuHomePhabricator

Enable 1080p (aka full-hd) support in TMH
Closed, ResolvedPublic

Description

I have uploaded a video: https://commons.wikimedia.org/wiki/File:Chinese_Fishing_nets.webm

which is 1920x1080p, to my surprise, the highest render target was 720p.

It seems like tmh has 720p as highest target hard coded.

Please add at least 1080p, preferably 4K :)


Version: unspecified
Severity: enhancement

Details

Reference
bz71705

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:48 AM
bzimport set Reference to bz71705.
bzimport added a subscriber: Unknown Object (MLST).

A quick glance at the code suggests that it's mostly config... Shouldn't be too difficult

If by config you mean a static value at the top of a class, yes ;)

Change 165243 had a related patch set uploaded by Brion VIBBER:
Quick add of full-HD (1080p) transcode configs for TMH

https://gerrit.wikimedia.org/r/165243

Patch adds configs for 1080p in ogv, webm, and mp4, and default-enables the webm one.

Only very lightly tested, may need tweaks to the settings.

mdale wrote:

Note TMH already makes the source available, so this is basically an additional 1080P version where higher quality 1080P or 4K is uploaded.

Change 165243 merged by jenkins-bot:
Quick add of full-HD (1080p) transcode configs for TMH

https://gerrit.wikimedia.org/r/165243

1080p transcodes are now appearing on commons.

*there are very few transcodes that are timing out so far, which surprised me. Maybe most of the HD vids on commons are short.
*enabling the new transcode format has made tmh unresponsive to newly uploaded video. A similar thing happened when 160p was enabled. I totally didnt realize when I saw this bug that that would happen, but its something we should probably keep in mind for the future, and probably do more outreach next time when a new transcode format is enabled.