| Jdlrobson | |
| Oct 8 2014, 12:11 AM |
| F15097: Screen_Shot_2014-10-07_at_5.11.44_PM.png | |
| Dec 24 2014, 7:42 PM |
| F15098: Screen_Shot_2014-10-07_at_5.18.38_PM.png | |
| Nov 22 2014, 3:52 AM |
Duplicate error messages
Navigate to Special:Watchlist whilst not logged in
You get two messages.
Expected:
You should just get the first styled message
We should look to consolidate our own custom code with that in core...
Version: unspecified
Severity: normal
Attached:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Don't show duplicate messages in LoginForm | mediawiki/extensions/MobileFrontend | master | +4 -1 |
bingle-admin wrote:
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/dDj3Id6L
I'd suggest styling the alert box instead of headmsg and using our own custom message which includes the bold text.
Created attachment 16700
Similarly, if you hit an error you see two alert boxes. We should probably only show one.
Attached:
Florna seems to have made a start to this - might be some ideas there - https://gerrit.wikimedia.org/r/#/c/165248/4
Yeah, it was an idea (before i saw this bug today), maybe we can use it someway :) Comments are welcome!
https://gerrit.wikimedia.org/r/165634 will take care of this if it was to move to stable.
I think we need to kill our custom login code.
gerritadmin wrote:
Change 165634 had a related patch set uploaded by Florianschmidtwelzow:
Use desktop login/account creation form in alpha
gerritadmin wrote:
Change 165634 merged by jenkins-bot:
Use desktop login/account creation form in alpha
Jon, the patch is live since wmf5 (since Wednesday, 29 October 2014 for all Wikipedias). We had no related bug reports (iirc) and it seems to work fine, what do you think: Can we move it to beta? :)
Using the desktop login form has various issues still and is not going to be ready any time soon.
Is there any way we can make the stable/beta site version of our existing login form use this mechanism and override the messages?
Change 183028 had a related patch set uploaded (by Florianschmidtwelzow):
Don't show duplicate messages in LoginForm