Page MenuHomePhabricator
Create Task
Maniphest T73772

Argument 1 passed to SidebarHookHandlers::onParserAfterParse() must be an instance of Parser
Closed, ResolvedPublic
Actions

Description

Catchable fatal error: Argument 1 passed to Wikibase\Client\Hooks\SidebarHookHandlers::onParserAfterParse() must be an instance of Parser, none given at /srv/mediawiki/php-1.25wmf1/extensions/Wikidata/extensions/Wikibase/client/includes/hooks/SidebarHookHandlers.php on line 123

http://en.wikipedia.org/w/index.php?title=Special:MathShowImage&hash=24a17d2e2b000c187e42eafb8faf1059&mode=0

Backtrace:
#0 /srv/mediawiki/php-1.25wmf1/extensions/Wikidata/extensions/Wikibase/client/includes/hooks/SidebarHookHandlers.php(123): Wikibase\Client\Hooks\SidebarHookHandlers::onParserAfterParse()
#1 [internal function]: Wikibase\Client\Hooks\SidebarHookHandlers::onParserAfterParse()
#2 /srv/mediawiki/php-1.25wmf1/includes/Hooks.php(206): call_user_func_array('\Wikibase\Clien...', Array)
#3 /srv/mediawiki/php-1.25wmf1/includes/GlobalFunctions.php(3991): Hooks::run('ParserAfterPars...', Array, NULL)
#4 /srv/mediawiki/php-1.25wmf1/extensions/Math/SpecialMathShowImage.php(97): wfRunHooks('ParserAfterPars...')
#5 /srv/mediawiki/php-1.25wmf1/includes/specialpage/SpecialPage.php(363): SpecialMathShowImage->execute(NULL)
#6 /srv/mediawiki/php-1.25wmf1/includes/specialpage/SpecialPageFactory.php(562): SpecialPage->run(NULL)
#7 /srv/mediawiki/php-1.25wmf1/includes/MediaWiki.php(275): SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
#8 /srv/mediawiki/php-1.25wmf1/includes/MediaWiki.php(584): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.25wmf1/includes/MediaWiki.php(435): MediaWiki->main()
#10 /srv/mediawiki/php-1.25wmf1/index.php(46): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): require('/srv/mediawiki/...')

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=56769

Details

Reference
bz71772
SubjectRepoBranchLines +/-
Avoid fatal in ParserAfterParser hook handlingmediawiki/extensions/Wikibasewmf/1.25wmf12c+11 -16
Avoid fatal in ParserAfterParser hook handlingmediawiki/extensions/Wikibasemaster+11 -16
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:53 AM
• bzimport added a project: Math.
• bzimport set Reference to bz71772.
• bzimport added a subscriber: Unknown Object (MLST).
aude created this task.Oct 8 2014, 12:49 AM
• bzimport added a comment.Oct 8 2014, 8:06 AM

gerritadmin wrote:

Change 165440 had a related patch set uploaded by Thiemo Mättig (WMDE):
Workaround for invalid ParserAfterParse hook call

https://gerrit.wikimedia.org/r/165440

aude added a comment.Oct 8 2014, 12:22 PM

problem is that SpecialMathShowImage is calling wfRunHooks('ParserAfterParse') with no parameters, inconsistent with the hook definition:

www.mediawiki.org/wiki/Manual:Hooks/ParserAfterParse

so, in the Wikibase hook handler, $parser and other parameters are null.

it would be much better if Math would directly call whatever specific method(s) that can save the file, rather than triggering the hook.

• bzimport added a comment.Oct 8 2014, 2:51 PM

physik wrote:

would it be better to user wfRunHooks('ParserAfterParse' , '', null ); instead

• bzimport added a comment.Oct 8 2014, 3:00 PM

gerritadmin wrote:

Change 165488 had a related patch set uploaded by Aude:
Workaround for invalid ParserAfterParse hook call

https://gerrit.wikimedia.org/r/165488

• bzimport added a comment.Oct 9 2014, 6:22 PM

gerritadmin wrote:

Change 165440 merged by jenkins-bot:
Workaround for invalid ParserAfterParse hook call

https://gerrit.wikimedia.org/r/165440

• bzimport added a comment.Oct 9 2014, 6:22 PM

gerritadmin wrote:

Change 165488 merged by jenkins-bot:
Workaround for invalid ParserAfterParse hook call

https://gerrit.wikimedia.org/r/165488

aude added a comment.Dec 11 2014, 3:53 PM

seems the bug is happening again.

Argument 1 passed to Wikibase\Client\Hooks\DataUpdateHookHandlers::onParserAfterParse() must be an instance of Parser, undefined variable given in /srv/mediawiki/php-1.25wmf11/extensions/Wikidata/extensions/Wikibase/client/includes/hooks/DataUpdateHookHandlers.php on line 73

also seeing:

#012Warning: onParserAfterParse() expects exactly 3 parameters, 0 given in /srv/mediawiki/php-1.25wmf11/extensions/Wikidata/extensions/Wikibase/client/includes/hooks/DataUpdateHookHandlers.php on line 73

gerritbot added a project: Patch-For-Review.Dec 11 2014, 3:54 PM

Change 179143 had a related patch set uploaded (by Aude):
Avoid fatal in ParserAfterParser hook handling

https://gerrit.wikimedia.org/r/179143

Patch-For-Review

aude added a comment.Dec 11 2014, 3:55 PM

would also like this fixed in the Math extension. i would need to look at the code again, but really don't think it should be calling the hook. there must be another solution.

gerritbot added a comment.Dec 11 2014, 4:04 PM

Change 179143 merged by jenkins-bot:
Avoid fatal in ParserAfterParser hook handling

https://gerrit.wikimedia.org/r/179143

aude mentioned this in rEWBA4d3e6cc7cfee: Avoid fatal in ParserAfterParser hook handling.Dec 11 2014, 4:04 PM
gerritbot added a comment.Dec 15 2014, 11:35 PM

Change 180067 had a related patch set uploaded (by Aude):
Avoid fatal in ParserAfterParser hook handling

https://gerrit.wikimedia.org/r/180067

Patch-For-Review

gerritbot added a comment.Dec 16 2014, 12:27 AM

Change 180067 merged by jenkins-bot:
Avoid fatal in ParserAfterParser hook handling

https://gerrit.wikimedia.org/r/180067

aude mentioned this in rEWBA412a1d475d5d: Avoid fatal in ParserAfterParser hook handling.Dec 16 2014, 12:27 AM
Diffusion mentioned this in rMEXTf3f7eae8b7e0: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Mar 11 2015, 6:22 AM
TheDJ mentioned this in T99212: onParserAfterParse() expects exactly 1 parameter, 0 given in /srv/mediawiki/php-1.26wmf5/extensions/Graph/Graph.body.php on line 31.May 15 2015, 9:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL