Page MenuHomePhabricator
Create Task
Maniphest T73825

VisualEditor: [Regression pre-wmf3] Citation dialog inserts empty reference
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

1.Open a page with VE
2.Insert Cite>Website/News/Journal etc

Observed Result:
All citation notes are getting added as basic reference, opening them opens the basic reference dialog instead of the citation dialog.

Environment:Betalabs

Version: unspecified
Severity: major

Details

Reference
bz71825

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:56 AM
• bzimport added projects: VE-deploy-2014-10-09, VisualEditor-EditingTools.
• bzimport set Reference to bz71825.
Ryasmeen created this task.Oct 8 2014, 7:19 PM
Ryasmeen added a comment.Oct 8 2014, 7:30 PM

Created attachment 16719
Screenshot

Attached:

Screen_Shot_2014-10-08_at_12.30.11_PM.png (405×1 px, 109 KB)

Catrope added a comment.Oct 8 2014, 7:32 PM

This is happening because the references inserted by the citation dialog are empty, they don't have a template in them like they should.

gerritbot added a comment.Oct 8 2014, 7:56 PM

Change 165592 had a related patch set uploaded by Catrope:
Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone

https://gerrit.wikimedia.org/r/165592

gerritbot added a comment.Oct 8 2014, 7:57 PM

Change 165593 had a related patch set uploaded by Catrope:
Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone

https://gerrit.wikimedia.org/r/165593

gerritbot added a comment.Oct 8 2014, 8:04 PM

Change 165592 merged by jenkins-bot:
Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone

https://gerrit.wikimedia.org/r/165592

gerritbot added a comment.Oct 8 2014, 8:06 PM

Change 165593 merged by jenkins-bot:
Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone

https://gerrit.wikimedia.org/r/165593

Jdforrester-WMF added a comment.Oct 8 2014, 8:14 PM

(Core pull-through not yet merged but otherwise fixed.)

Ryasmeen added a comment.Oct 8 2014, 10:01 PM

Verified the fix in Betalabs

Ryasmeen added a comment.Oct 9 2014, 11:01 PM

Verified the fix in test2

Ryasmeen added a comment.Oct 16 2014, 11:41 PM

Verified the fix in production

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 1:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL