Page MenuHomePhabricator
Create Task
Maniphest T73900

VisualEditor: Blue link / red link logic should descend into links inside non-transclusion generated content nodes
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

For the very few GCNs that generate wiki-link links (class=new etc.).

Version: unspecified
Severity: trivial

Details

Reference
bz71900
SubjectRepoBranchLines +/-
MWSaveDialog: Run links through a render function for preview & visual diffmediawiki/extensions/VisualEditormaster+108 -36
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Lowest.Nov 22 2014, 3:44 AM
• bzimport added a project: VisualEditor-MediaWiki.
• bzimport set Reference to bz71900.
Jdforrester-WMF created this task.Oct 9 2014, 9:47 PM
• Elitre added a comment.Oct 17 2014, 5:28 PM

In the top template at https://it.wikipedia.org/wiki/Korova_Milk_Bar?veaction=edit "migliorare questa voce", which leads to https://it.wikipedia.org/w/index.php?title=Korova_Milk_Bar&action=edit , shows up as red. This is related to this bug, I guess?

Krenair added a comment.Oct 17 2014, 6:26 PM

Yeah. More with bug 65353 really

Krenair added a comment.Oct 17 2014, 6:51 PM

(Uploaded Gerrit change 167249 for that)

Jdforrester-WMF added a project: VisualEditor.Nov 24 2014, 4:10 PM
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
Jdforrester-WMF merged a task: T104602: Red links inside templates should display as red .Jul 3 2015, 4:00 PM
Jdforrester-WMF added subscribers: • Whatamidoing-WMF, Aklapper.
Jdforrester-WMF merged a task: T78472: When I changed the website link in an infobox all other links got redlinks.Jul 3 2015, 4:20 PM
Jdforrester-WMF added a subscriber: rugk.
Esanders subscribed.Mar 31 2017, 9:35 AM

What did you mean by non-template GCN? Extension nodes?

gerritbot subscribed.Mar 31 2017, 9:53 AM

Change 345607 had a related patch set uploaded (by Esanders; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] MWSaveDialog: Run links through a render function for preview & visual diff

https://gerrit.wikimedia.org/r/345607

gerritbot added a project: Patch-For-Review.Mar 31 2017, 9:53 AM
Jdforrester-WMF claimed this task.Apr 1 2017, 3:11 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from Freezer to TR1: Releases on the VisualEditor board.
In T73900#3146112, @Esanders wrote:

What did you mean by non-template GCN? Extension nodes?

Yes.

gerritbot added a comment.Apr 1 2017, 3:22 PM

Change 345607 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWSaveDialog: Run links through a render function for preview & visual diff

https://gerrit.wikimedia.org/r/345607

Jdforrester-WMF closed this task as Resolved.Apr 1 2017, 3:26 PM
Jdforrester-WMF edited projects, added MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)); removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 1 2017, 3:26 PM
Jdforrester-WMF added a project: VisualEditor-VisualDiffs.Apr 10 2017, 11:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL