Page MenuHomePhabricator

Exception Caught: Internal error in ApiFormatXml::recXmlPrint: (redirlinks, ...) has integer keys without _element value. Use ApiResult::setIndexedTagName().
Closed, ResolvedPublic

Description

Exception Caught: Internal error in ApiFormatXml::recXmlPrint: (redirlinks, ...) has integer keys without _element value. Use ApiResult::setIndexedTagName().

I get this when trying to save via AWB in many pages.

https://en.wikipedia.org/wiki/Wikipedia_talk:AutoWikiBrowser/Bugs#error_message_appearing_when_saving


Version: unspecified
Severity: normal

Details

Reference
bz71907

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:44 AM
bzimport set Reference to bz71907.
bzimport added a subscriber: Unknown Object (MLST).

Problem is in loading and on in saving. Problem occurs when trying to get backlinks.

It seems there's a problem with an API request for list=backlinks.

Reports:

https://en.wikipedia.org/wiki/Wikipedia_talk:AutoWikiBrowser/Bugs#error_message_appearing_when_loading_with_auto-tagger_on

https://en.wikipedia.org/wiki/Wikipedia_talk:WPCleaner#Error_when_getting_the_disambiguation_links_for_a_page

https://lists.wikimedia.org/pipermail/mediawiki-api/2014-October/003380.html

Copying from the email above:

For example, the request below returns now an internal API error, but it
was working correctly before.

Request:
https://fr.wikipedia.org/w/api.php?bltitle=BNF&action=query&blredirect=&list=backlinks&format=xml&bllimit=max

Result:
<?xml
version="1.0"?><api servedby="mw1053"><error
code="internal_api_error_MWException" info="Exception
Caught: Internal error in ApiFormatXml::recXmlPrint: (redirlinks, ...) has
integer keys without _element value. Use
ApiResult::setIndexedTagName()." xml:space="preserve" /></api>

gerritadmin wrote:

Change 166030 had a related patch set uploaded by Umherirrender:
Set redirlinks indexed tag name on list=backlinks

https://gerrit.wikimedia.org/r/166030

gerritadmin wrote:

Change 166030 merged by jenkins-bot:
Set redirlinks indexed tag name on list=backlinks

https://gerrit.wikimedia.org/r/166030

gerritadmin wrote:

Change 166051 had a related patch set uploaded by Anomie:
Set redirlinks indexed tag name on list=backlinks

https://gerrit.wikimedia.org/r/166051

gerritadmin wrote:

Change 166052 had a related patch set uploaded by Anomie:
Set redirlinks indexed tag name on list=backlinks

https://gerrit.wikimedia.org/r/166052

Once the patches are merged then can be added to the next available SWAT window.

The change that caused this (https://gerrit.wikimedia.org/r/#/c/155591/) also changed the JSON format: redirlinks used to be an array, now it's an object ("redirlinks":[{"pageid":1,"ns":0,"title":"Main Page"}] ==> "redirlinks":{"1":{"pageid":1,"ns":0,"title":"Main Page"}}). It was probably also not intended.

gerritadmin wrote:

Change 166085 had a related patch set uploaded by Anomie:
API: Fix ApiQueryBacklinks redirlinks

https://gerrit.wikimedia.org/r/166085

gerritadmin wrote:

Change 166132 had a related patch set uploaded by Anomie:
API: Fix ApiQueryBacklinks redirlinks

https://gerrit.wikimedia.org/r/166132

gerritadmin wrote:

Change 166133 had a related patch set uploaded by Anomie:
API: Fix ApiQueryBacklinks redirlinks

https://gerrit.wikimedia.org/r/166133

gerritadmin wrote:

Change 166051 abandoned by Anomie:
Set redirlinks indexed tag name on list=backlinks

Reason:
I865aad6485a2598c9e574ab5c38e8e0923d11ddd instead

https://gerrit.wikimedia.org/r/166051

gerritadmin wrote:

Change 166052 abandoned by Anomie:
Set redirlinks indexed tag name on list=backlinks

Reason:
I865aad6485a2598c9e574ab5c38e8e0923d11ddd instead

https://gerrit.wikimedia.org/r/166052

gerritadmin wrote:

Change 166085 merged by jenkins-bot:
API: Fix ApiQueryBacklinks redirlinks

https://gerrit.wikimedia.org/r/166085

gerritadmin wrote:

Change 166132 merged by jenkins-bot:
API: Fix ApiQueryBacklinks redirlinks

https://gerrit.wikimedia.org/r/166132

gerritadmin wrote:

Change 166133 merged by jenkins-bot:
API: Fix ApiQueryBacklinks redirlinks

https://gerrit.wikimedia.org/r/166133