Page MenuHomePhabricator

shouldSkip and transition do not properly execute on next/prev
Open, HighPublic

Description

shouldSkip used to execute correctly when you clicked next. It would first get the ID of the next guider, then see if skipping was needed. See https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGuidedTour.git/40e856360e4ba377242c172b036477aebf740ad9/modules%2Fmediawiki.libs.guiders%2Fmediawiki.libs.guiders.js#L774 .

The same should happen with transition, but now it works for neither legacy shouldSkip nor AFAICT transition.

For an example of the regression on legacy, try going to https://en.wikipedia.org/wiki/Wikipedia:TWA/1/Start?tour=twa1&step=6 then click next.

There is a shouldSkip on step 7 (the one you hit when you click next):

shouldSkip: function () {
                return mw.config.get( 'wgUserId' )  !== null;
}

Thus, it should automatically skip step 7, since you're logged in. However, this doesn't work.

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:46 AM
bzimport set Reference to bz71927.
bzimport added a subscriber: Unknown Object (MLST).
Deskana renamed this task from shouldSkip and transition do not properly execute on next/prev to VisualEditor.Aug 30 2018, 1:31 PM
Deskana renamed this task from VisualEditor to shouldSkip and transition do not properly execute on next/prev.Aug 30 2018, 1:47 PM
This comment was removed by Pppery.

Took a quick look at this and found it was more complicated to fix than my level of motivation to fix it, or what is likely to get reviewed.

Change #1031113 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/extensions/GuidedTour@master] Pass transition event when clicking next or back

https://gerrit.wikimedia.org/r/1031113