Page MenuHomePhabricator

VisualEditor: [Regression pre-wmf4] After placing the cursor on a slug, placing it anywhere in the page which follows that particular slug throws "TypeError: Cannot read property 'getSelection' of null"
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Insert a bullet or numbered list
3.Keep on adding indentation to the list to create slugs
4.Place your cursor inside the slug to add an item to the list
Observed Result:
It throws error in the console:TypeError: Cannot read property 'getSelection' of null

See the screenshot attached


Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-10-15_at_1.47.17_PM.png (462×1 px, 67 KB)

Details

Reference
bz72095

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:56 AM
bzimport set Reference to bz72095.

Rephrasing the bug its not only for slugs created from the list but rather a generic issue for all kind of slugs.It happens if you place your cursor in a slug and then place your cursor anywhere in the page which follows the slug.
If you place your cursor somehwere above the slug , you wont get the error.

gerritadmin wrote:

Change 166884 had a related patch set uploaded by Catrope:
Followup 2432cbf: add recursion guard to updateSlug

https://gerrit.wikimedia.org/r/166884

gerritadmin wrote:

Change 166884 merged by jenkins-bot:
Followup 2432cbf: add recursion guard to updateSlug

https://gerrit.wikimedia.org/r/166884

Verified the fix in production