| • MZMcBride | |
| Oct 20 2014, 6:00 PM |
| F15033: Screen_Shot_2014-10-20_at_2.00.37_PM.png | |
| Nov 22 2014, 3:51 AM |
When I go to https://en.wikipedia.org/wiki/Main_Page I'm hit with a fundraising banner that has a black X in the corner. Clicking the X makes the banner go away only temporarily currently. When the page is refreshed, the banner returns. The dismiss functionality lacks persistence. This is a major issue.
Version: wmf-deployment
Severity: major
URL: https://en.wikipedia.org/wiki/Main_Page
Created attachment 16822
Screenshot of fundraising banner on https://en.wikipedia.org/wiki/Main_Page, 2014-10-20
Attached:
https://meta.wikimedia.org/wiki/MediaWiki:Centralnotice-template-B14_1020_enUS_dsk_rpta
I believe this is the controlling page. I don't see the cookie logic off-hand. What's going on here?
I found the problem, this was mistakenly cloned from a (one-off) previous banner where we had removed the hide-cookie setting since that banner was only ever to be shown once. When this banner was changed to show up multiple times, we forgot to re-add the hide cookie.
The test ended approximately 20 minutes after this bug was reported. We won't be using this banner again, and I'll add a check to our internal documentation to ensure this doesn't occur again.