Page MenuHomePhabricator

VisualEditor: [Regression pre-wmf5] Scroll bar is appearing while opening a link inspector
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Open Link inspector in an empty line

Observed Result:
A scroll bar is appearing inside the link inspector

See the screenshot attached


Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-10-21_at_3.32.07_PM.png (236×497 px, 18 KB)

Details

Reference
bz72338

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:55 AM
bzimport set Reference to bz72338.

Proximate cause is https://gerrit.wikimedia.org/r/#/c/167446/ , it was working before that change.

What seems to be going on is that there's a browser bug in Chrome that causes the inspector's body to immeasurably have a slightly greater height if the opacity of the Open button is not equal to 1. That's why this bug is only reproducible in creation mode, and the scrollbar goes away as soon as you type: the Open button is initially disabled (opacity:0.5), then enabled when you type something (opacity:1).

If you want entertainment, inspect an enabled Open button, add opacity:0.999; to it and toggle it off and on a few times.

gerritadmin wrote:

Change 168206 had a related patch set uploaded by Esanders:
Increase inspector height by 1 to deal with Chrome opacity bug

https://gerrit.wikimedia.org/r/168206

gerritadmin wrote:

Change 168206 merged by jenkins-bot:
Increase inspector height by 1 to deal with Chrome opacity bug

https://gerrit.wikimedia.org/r/168206

Verified the fix in production