Page MenuHomePhabricator
Create Task
Maniphest T74343

Unclosed table tags cause user input to be lost on page preview with HHVM
Closed, ResolvedPublic
Actions

Description

Using two unclosed <table> tags on a page sometimes causes MediaWiki to lose user input on page preview.

Steps to reproduce:

  1. Edit a page on enwiki and replace all the text in the edit window with the following (without saving):
<table><table>Some text 2. Click on "Show preview". You might need to click a few times; this is an intermittent behaviour. It usually took two or three times for me. 3. The text that we added disappears from the edit window, and the following error is displayed: "Some parts of the edit form did not reach the server; double-check that your edits are intact and try again." This looks like it might be related to HTML Tidy and bug 65747, but I'm not sure of the real cause. -------------------------- **Version**: unspecified **Severity**: normal

Details

Reference
bz72343

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:55 AM
• bzimport added a project: MediaWiki-Page-editing.
• bzimport set Reference to bz72343.
• bzimport added a subscriber: Unknown Object (MLST).
MrStradivarius created this task.Oct 22 2014, 4:36 AM
MrStradivarius added a comment.Oct 22 2014, 8:51 AM

Also, I was using HHVM when I saw this happen, which might be relevant. And it might be related to bug 72345.

MrStradivarius added a comment.Oct 22 2014, 9:06 AM

After further testing, I've found that this only occurs when I have HHVM enabled, so I'm adding the HHVM keyword.

PleaseStand added a comment.Oct 22 2014, 10:16 AM

Yes, I also tried this without HHVM on and I didn't see the problem. After turning it on (by setting the hhvm=true cookie), I do see it, though only for some servers but not others. It's actually only necessary to have a single unclosed table tag.

The problem is indeed that the unclosed table tag is getting through to the output, probably because as stated in an HTML comment, "Tidy was unable to run". That causes wpTextbox1 (the main text box) to end up outside the form in the browser's DOM, and that's why it takes at least two clicks on "Show preview" to reproduce.

Anomie added a comment.Oct 22 2014, 7:09 PM
  • This bug has been marked as a duplicate of bug 72345 ***
Aklapper removed subscribers: Anomie, • wikibugs-l-list.Oct 16 2020, 5:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL