Page MenuHomePhabricator

VisualEditor: Applying a rich annotation to an image causes inspector to open then close quickly in Chrome; die in Firefox
Open, MediumPublic

Description

inspector opens up on the left side in FF 33.0

Environment- beta

1> In VE, insert a media(with any settings but no content in "Caption") to blank page.

2> Highlight the image and select link or language from the toolbar.The inspector opens and closes quickly.

This happens in chrome 38 only.

In FF 33.0, when you do the above steps, the inspectors do not open on top of the image.But always on the left side in the CE .See screenshot.


Version: unspecified
Severity: minor

Attached:

s.png (846×1 px, 80 KB)

Details

Reference
bz72431

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:44 AM
bzimport set Reference to bz72431.

Now reproducible in test2.

1> insert a media with no captions.Highlight the image and select to apply link or language.
2> Link or language inpsector opens and closes quickly.

I believe that this is describing intentional functionality for links? You can't make an image into a link in wikitext (there's a distinct feature about image target but that's tracked elsewhere).

But yes, this needs to be cleaned up a bit (especially the different behaviour between Firefox and Chrome).

(In reply to James Forrester from comment #2)

I believe that this is describing intentional functionality for links? You
can't make an image into a link in wikitext (there's a distinct feature
about image target but that's tracked elsewhere).

But yes, this needs to be cleaned up a bit (especially the different
behavior between Firefox and Chrome).

I also noticed that when i try to apply link to images having caption,the link inspector opens with the caption text as link target in the input field(which i thought was fine).

Environment-test2, beta, production
steps-
1> insert a media with a caption(could be an internal link or text).Highlight the image and select to apply link.
2> Link inspector opens on top of the image, populated with the caption in the input field.
3> Click done and the inspector closes.See screenshot.

Is this expected?

Created attachment 16939
Caption appearing in the link target field

Attached:

caption1.png (416×1 px, 39 KB)