Page MenuHomePhabricator
Create Task
Maniphest T74445

Special:Version produces warning when there's an open_basedir restriction, when checking for $wgGitBin
Closed, ResolvedPublic
Actions

Description

Special:Version is using is_file() to check if $wgGitBin is set to a valid git binary path, but that produces a warning if there's an open_basedir restriction in effect. This only happens when there are extensions installed downloaded from git.

We should probably use error handling to prevent that warning from popping up.

Steps to reproduce:

  • Download an extension from Gerrit.
    • Example: go to the extensions directory and use git clone https://gerrit.wikimedia.org/r/p/mediawiki/extensions/UserMerge
  • Load the extension in LocalSettings.php.
    • Example: wfLoadExtension( 'UserMerge' );
  • Be sure php.ini has open_basedir set to MediaWiki install directory, and probably a temp directory like /tmp
  • Go to Special:Version and it should display the warning (if your error_reporting configuration is not hiding it).
NOTE: The warning will be displayed only once, then the information will be cached. To display the warning again you should clear the object cache. In case the object cache is in database, simply issue a truncate table objectcache; on the database and reload the Special:Version page again to see the warning.

Original Version: 1.23.5
Latest version reproduced: 1.35.0-alpha
URL: https://www.mediawiki.org/wiki/Thread:Project:Support_desk/Odd_occurrence_when_viewing_Special:Version

Details

Reference
bz72445
SubjectRepoBranchLines +/-
GitInfo: Suppress is_file() warnings when checking $wgGitBinmediawiki/coremaster+5 -1
Version produces warning when checking for $wgGitBinmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:45 AM
• bzimport added a project: MediaWiki-Special-pages.
• bzimport set Reference to bz72445.
• bzimport added a subscriber: Unknown Object (MLST).
Ciencia_Al_Poder created this task.Oct 23 2014, 7:24 PM
Aklapper triaged this task as Lowest priority.Mar 23 2015, 5:15 PM
Aklapper added a project: good first task.
Aklapper set Security to None.
• Reguyla moved this task from To triage to Special:Version on the MediaWiki-Special-pages board.May 26 2015, 1:56 AM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJan 10 2017, 10:43 AM
xSavitar added a project: Africa-Wikimedia-Developers.Jul 3 2017, 8:49 PM
xSavitar moved this task from Backlog to New Contributor's Tasks (Incoming) on the Africa-Wikimedia-Developers board.
samuelguebo added subscribers: xSavitar, samuelguebo.EditedJul 4 2017, 1:13 AM

Hello @D3r1ck01, I took a look at https://www.mediawiki.org/wiki/Thread:Project:Support_desk/Odd_occurrence_when_viewing_Special:Version and the issue seems to have been fixed if I am not wrong. If this is the case I'll try to pick another featured task from our list.

Ciencia_Al_Poder added a comment.Jul 4 2017, 11:22 AM

Hi @samuelguebo

I've tested it and it's still current in MediaWiki 1.29-rc.0, but maybe not so easy to reproduce, because apparently it only attempts to check for the git bin when there are extensions installed downloaded directly from git. Special:ExtensionDistribution on mediawiki.org already include some git metadata files with all the information, and MediaWiki doesn't need to retrieve this information from git.

I'm going to update the task description with clear steps to reproduce.

Ciencia_Al_Poder updated the task description. (Show Details)Jul 4 2017, 11:25 AM
Ciencia_Al_Poder removed a subscriber: • wikibugs-l-list.
xSavitar added a comment.Aug 5 2017, 5:50 PM
In T74445#3403973, @Ciencia_Al_Poder wrote:

Hi @samuelguebo

I've tested it and it's still current in MediaWiki 1.29-rc.0, but maybe not so easy to reproduce, because apparently it only attempts to check for the git bin when there are extensions installed downloaded directly from git. Special:ExtensionDistribution on mediawiki.org already include some git metadata files with all the information, and MediaWiki doesn't need to retrieve this information from git.

I'm going to update the task description with clear steps to reproduce.

@samuelguebo, you now have the steps to reproduce, you can work on this right? Thanks @Ciencia_Al_Poder :)

samuelguebo added a comment.Aug 5 2017, 7:20 PM

Hello @D3r1ck01,

Indeed the description is more clear now. I will work on it. Thanks @Ciencia_Al_Poder

xSavitar mentioned this in T169573: Africa Wikimedia Developers Leaderboard Monthly Statistics for the year 2017.Aug 9 2017, 3:51 PM
rosalieper claimed this task.Jan 20 2018, 8:15 PM

@samuelguebo I wish to work on this if you are no more on it. Thanks :)

samuelguebo added a comment.Jan 20 2018, 10:56 PM

Sure, you may go on and work on it.

Le 20 janv. 2018 20:16, "rosalieper" <no-reply@phabricator.wikimedia.org> a
écrit :

rosalieper added a comment.

@samuelguebo https://phabricator.wikimedia.org/p/samuelguebo/ I wish to
work on this if you are no more on it. Thanks :)

*TASK DETAIL*
https://phabricator.wikimedia.org/T74445

*EMAIL PREFERENCES*
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

*To: *rosalieper
*Cc: *samuelguebo, D3r1ck01, TerraCodes, Ciencia_Al_Poder, Asad_Ali_Palijo,
JamieTubers, Lsherwinforone, Soteriaspace, RazeSoldier, Jayprakash12345,
JakeTheDeveloper, Eugene233, Ptolusque, Zoranzoki21, Sethakill, Zppix,
rosalieper, MuhammadShuaib, Wong128hk, Flixtey, SimmeD, Jdlrobson

gerritbot subscribed.Jan 22 2018, 3:44 PM

Change 405725 had a related patch set uploaded (by Rosalieper; owner: Rosalieper):
[mediawiki/core@master] Version produces warning when checking for $wgGitBin

https://gerrit.wikimedia.org/r/405725

gerritbot added a project: Patch-For-Review.Jan 22 2018, 3:44 PM
xSavitar moved this task from New Contributor's Tasks (Incoming) to Tasks in progress (Doing) on the Africa-Wikimedia-Developers board.Jan 22 2018, 5:21 PM
xSavitar added a comment.Jan 28 2018, 1:16 PM

Le 20 janv. 2018 20:16, "rosalieper" <no-reply@phabricator.wikimedia.org> a
écrit :

@samuelguebo, maybe next time you can reply on the phab ticket itself to avoid email content (when replying via email) to be attached? Thanks :)

samuelguebo added a comment.Jan 29 2018, 12:25 PM

My bad, thanks @D3r1ck01 for notifying me.

Noella94 removed rosalieper as the assignee of this task.Feb 19 2018, 8:41 AM
Noella94 added a subscriber: rosalieper.
Noella94 assigned this task to rosalieper.Feb 19 2018, 8:45 AM
gerritbot added a comment.Feb 27 2018, 4:37 PM

Change 405725 abandoned by Rosalieper:
Version produces warning when checking for $wgGitBin

https://gerrit.wikimedia.org/r/405725

rosalieper removed rosalieper as the assignee of this task.Feb 27 2018, 4:37 PM
Reedy removed a project: Patch-For-Review.Feb 27 2018, 4:40 PM
Reedy updated the task description. (Show Details)
RazeSoldier subscribed.Feb 27 2018, 4:57 PM

@rosalieper Are you still work it? If not, and if I can reproduce this error, I can work it.

xSavitar moved this task from Tasks in progress (Doing) to New Contributor's Tasks (Incoming) on the Africa-Wikimedia-Developers board.Mar 3 2018, 9:28 AM
rosalieper added a comment.Mar 3 2018, 9:30 AM

@RazeSoldier You can go ahead

RazeSoldier added a comment.EditedMar 3 2018, 1:11 PM

I follow step of the reproduce (except download an extension and load it step), only open_basedir set to MediaWiki install directory in LocalSettings.php, then my wiki was destroyed. I got two error messages:

  1. Warning: is_dir(): open_basedir restriction in effect. File(/tmp) is not within the allowed path(s): (w/) in w/includes/libs/filebackend/fsfile/TempFSFile.php on line 90
  2. Fatal error: Uncaught Error: Call to a member function getIP() on null in w/includes/user/User.php:2398 Stack trace: #0 w/includes/session/SessionBackend.php(712): User->getName() #1 w/includes/session/SessionBackend.php(596): MediaWiki\Session\SessionBackend->save() #2 [internal function]: MediaWiki\Session\SessionBackend->MediaWiki\Session\{closure}() #3 w/vendor/wikimedia/scoped-callback/src/ScopedCallback.php(76): call_user_func_array(Object(Closure), Array) #4 w/vendor/wikimedia/scoped-callback/src/ScopedCallback.php(56): Wikimedia\ScopedCallback->__destruct() #5 w/includes/session/SessionManager.php(886): Wikimedia\ScopedCallback::consume(NULL) #6 w/includes/session/SessionManager.php(310): MediaWiki\Session\SessionManager->getSessionFromInfo(Object(MediaWiki\Session\SessionInfo), Object(WebRequest)) #7 w/includes/session/SessionManager.php(244): MediaWiki\Session\SessionManager->getEmptySe in w/includes/user/User.php on line 2398

I am not sure this task describe these errors, they seem to affect the entire wiki, not just Special:Version.

Liuxinyu970226 subscribed.Mar 3 2018, 1:17 PM
Ciencia_Al_Poder added a comment.Mar 3 2018, 3:41 PM
In T74445#4020665, @RazeSoldier wrote:

I follow step of the reproduce (except download an extension and load it step), only open_basedir set to MediaWiki install directory in LocalSettings.php, then my wiki was destroyed. I got two error messages:

  1. Warning: is_dir(): open_basedir restriction in effect. File(/tmp) is not within the allowed path(s): (w/) in w/includes/libs/filebackend/fsfile/TempFSFile.php on line 90

The temp directory should be inside the open_basedir allowed paths. Or try to define $wgTmpDirectory to a path withing the allowed paths.

RazeSoldier added a comment.Mar 3 2018, 4:08 PM

I reproduce the error, but it looks like also caused when not load any extensions and skins.

Warning: is_file(): open_basedir restriction in effect. File(/usr/bin/git) is not within the allowed path(s): (/devmw/w:/tmp) in w/includes/GitInfo.php on line 228

RazeSoldier claimed this task.Mar 3 2018, 4:10 PM
RazeSoldier added a project: Patch-For-Review.Mar 4 2018, 2:02 AM
RazeSoldier moved this task from Backlog to Doing on the good first task board.

I push a patch. https://gerrit.wikimedia.org/r/#/c/416234/

xSavitar raised the priority of this task from Lowest to Medium.Mar 5 2018, 8:41 AM
xSavitar removed a project: Africa-Wikimedia-Developers.
xSavitar updated the task description. (Show Details)
RazeSoldier mentioned this in T196214: Special:Version and "Warning: is_file(): open_basedir restriction in effect. File(/usr/bin/git) is not within the allowed path(s)...".Jun 2 2018, 7:44 AM
RazeSoldier closed this task as a duplicate of T196214: Special:Version and "Warning: is_file(): open_basedir restriction in effect. File(/usr/bin/git) is not within the allowed path(s)...".
Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptJun 2 2018, 7:44 AM
RazeSoldier reopened this task as Open.Jun 2 2018, 7:45 AM

Oh, misoperation.

RazeSoldier merged a task: T196214: Special:Version and "Warning: is_file(): open_basedir restriction in effect. File(/usr/bin/git) is not within the allowed path(s)...".Jun 2 2018, 7:47 AM
RazeSoldier added subscribers: Noloader, Aklapper.
Liuxinyu970226 subscribed.Jun 2 2018, 2:53 PM
• Phabricator_maintenance moved this task from Doing to Backlog on the good first task board.Sep 24 2018, 9:38 AM
RazeSoldier added a comment.Feb 13 2020, 6:38 PM

Can someone review this simple patch?

TerraCodes unsubscribed.Feb 13 2020, 7:19 PM
gerritbot added a comment.May 22 2020, 1:14 PM

Change 416234 had a related patch set uploaded (by Aklapper; owner: 星耀晨曦):
[mediawiki/core@master] Checks if open_basedir include $wgGitBin before is_file()

https://gerrit.wikimedia.org/r/416234

Aklapper added a project: Platform Engineering.May 22 2020, 1:15 PM

Manually adding Platform Engineering as there is still a 30 line patch waiting for review

• eprodromou edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Engineering.May 26 2020, 8:28 PM
• eprodromou subscribed.

All right, we've intaken it for code review, thanks.

RazeSoldier updated the task description. (Show Details)Jun 27 2020, 5:10 PM
gerritbot added a comment.Jun 28 2020, 11:39 PM

Change 416234 merged by jenkins-bot:
[mediawiki/core@master] GitInfo: Suppress is_file() warnings when checking $wgGitBin

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /416234

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jun 29 2020, 12:00 AM
Krinkle closed this task as Resolved.Jun 29 2020, 1:30 AM
DannyS712 removed a project: Patch-For-Review.Jun 29 2020, 2:23 AM
samuelguebo unsubscribed.Jun 29 2020, 3:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL