Page MenuHomePhabricator

ENTER should submit the "Link with page" popup when adding a new site links from client
Open, LowPublic

Description

Currently, if I go to a Wikipedia article and then

  1. Click on "Add links"
  2. Fill the "Language" and "Page" fields

I'm not able to finish the process by just pressing ENTER at this point. It does nothing at all. So, I'm having to use the mouse again to click in the "Link with page" button.


Version: unspecified
Severity: normal
Whiteboard: u=dev c=frontend p=0 papercut

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:46 AM
bzimport set Reference to bz72712.
bzimport added a subscriber: Unknown Object (MLST).

gerritadmin wrote:

Change 171868 had a related patch set uploaded by Hoo man:
Allow submitting linkItem form with enter

https://gerrit.wikimedia.org/r/171868

gerritadmin wrote:

Change 171868 merged by jenkins-bot:
Allow submitting linkItem form with enter

https://gerrit.wikimedia.org/r/171868

I'm still not able to finish the process by just pressing ENTER (it seems the confirm button is not focused when the popup appears).

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lydia_Pintscher lowered the priority of this task from Medium to Low.Feb 7 2018, 4:23 PM
Lydia_Pintscher added a project: TestMe.
Tacsipacsi subscribed.

To clarify @He7d3r’s last comment, this form can be submitted by pressing the key:

Screenshot 2022-02-07 at 17-51-57 Kategória Lapok láthatatlanná vált wd sablonnal - Wikipédia.png (263×507 px, 14 KB)

But this one can be submitted by pressing the key only if the previous one was submitted by pressing the Link with page button (it can be pressed with the mouse or by tabbing to it and pressing the Space or key, but pressing the key in one of the text fields will break the further keyboard navigation):

Screenshot 2022-02-07 at 17-52-18 Kategória Lapok láthatatlanná vált wd sablonnal - Wikipédia.png (425×507 px, 52 KB)

(Tested with current production Wikibase Client version, commit 62809d0.)

Change 761469 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] linkitem: Focus final confirm button

https://gerrit.wikimedia.org/r/761469

Could someone review this patch? It’s been waiting for a +2 for over two years now.