Page MenuHomePhabricator

VisualEditor: [Regression wmf5] FocusableNodes not selectable when surface is blurred
Closed, ResolvedPublic

Description

  1. Open VE on a page that contains a focusable node
  2. Click out of the surface so it's blurred and the toolbar tools are greyed out (selection is a ve.dm.NullSelection)
  3. Try to select a focusable node by clicking on it
  4. Nothing happens
  5. Click to drop the cursor in some normal text
  6. Repeat #3, observe that it works now

This also causes bug 72719: double-clicking focusable nodes fires their double-click handler and opens the associated dialog, but the selection is still null, so the dialogs don't open with the right context.


Version: unspecified
Severity: major

Details

Reference
bz72721

Event Timeline

Change 169966 had a related patch set uploaded by Catrope:
Fix selection transitions between FocusableNodes and non-linear selections

https://gerrit.wikimedia.org/r/169966

Change 169966 merged by jenkins-bot:
Fix selection transitions between FocusableNodes and non-linear selections

https://gerrit.wikimedia.org/r/169966

Change 170370 had a related patch set uploaded by Catrope:
Fix selection transitions between FocusableNodes and non-linear selections

https://gerrit.wikimedia.org/r/170370

Change 170371 had a related patch set uploaded by Catrope:
Fix selection transitions between FocusableNodes and non-linear selections

https://gerrit.wikimedia.org/r/170371

Change 170371 merged by jenkins-bot:
Fix selection transitions between FocusableNodes and non-linear selections

https://gerrit.wikimedia.org/r/170371

Change 170370 merged by jenkins-bot:
Fix selection transitions between FocusableNodes and non-linear selections

https://gerrit.wikimedia.org/r/170370

Verified the fix in test2 and production (en.wiki)