Page MenuHomePhabricator

VisualEditor: [Regression] Ctrl+A no longer working since staging of slugs because a selection starting from a CE=false node in Chrome
Closed, ResolvedPublic8 Estimated Story Points

Description

Please.


Version: unspecified
Severity: major

Details

Reference
bz72725

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:47 AM
bzimport set Reference to bz72725.

Chromium bug, has been around for a year, but maybe we've made it more common by having ce=false slugs?

https://code.google.com/p/chromium/issues/detail?id=322444

http://jsfiddle.net/edg2s/afhq6ef0/

Solutions:

  1. Book-end the document with selectable but invisible content. Have to make sure this doesn't break ve.ce.getOffset.
  1. Register CTRL+A as a trigger and do it programmatically.

Further complicating the issue is CE true inside CE false inside CE true, as is the case with table cell editing. In this case CTRL+A should only select the cell contents, so any programmatic solution would have to be aware of that, and any book-end solution would have to work in these "sub-surfaces" as well.

*sigh* Chrome doesn't even let you set such a selection programmatically, so it appears book-ending is required. Although I'd like to do programmatic handling too to catch things like table and focusable node selections (where the native selection is in the paste target).

(In reply to Ed Sanders from comment #3)

*sigh* Chrome doesn't even let you set such a selection programmatically, so
it appears book-ending is required. Although I'd like to do programmatic
handling too to catch things like table and focusable node selections (where
the native selection is in the paste target).

So… gerrit 172039 didn't fix this. Is it do-able?

Jdforrester-WMF lowered the priority of this task from High to Medium.Jan 15 2015, 12:49 AM
Jdforrester-WMF set Security to None.

Slugs are now inserted with buttons which are ce=true