Page MenuHomePhabricator

Regular context menu trying to render on TableSelections
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Insert a table
2.Add a link inside a content cell
3.Click on the link in Edit mode

Observed Result:
It scrolls the page down and shows the context menu of link inspector at the bottom left corner of CE

See the screenshot attached


Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-10-30_at_10.26.15_PM.png (292×678 px, 19 KB)

Details

Reference
bz72802

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:52 AM
bzimport set Reference to bz72802.

In fact, after that point on, clicking on any cell scrolls the page to the bottom.

I couldn't get any strange behaviour when adding/editing links inside the cell. The only odd behaviour was when I tried to open the link inspector on a table selection using the keyboard shortcut (while the button is still greyed out). Being able to do that is a separate issue which I have fixed with
https://gerrit.wikimedia.org/r/#/q/topic:command-selection,n,z

Created attachment 17005
video capture

Hmm..I was actually pointing to the issue of scrolling to the end of page once you click on the link or any other cell after adding a link as you can see from this video capture

Attached:

Found the problem here. If the cell contains *only* a link then getAvailableTools says the whole cell is annotated and so tries to render the link inspector.

Change 170896 had a related patch set uploaded by Esanders:
Disable desktop context on table selections

https://gerrit.wikimedia.org/r/170896

Change 170896 merged by jenkins-bot:
Disable desktop context on table selections

https://gerrit.wikimedia.org/r/170896

Jdforrester-WMF renamed this task from VisualEditor: Regular context menu trying to render on TableSelections to Regular context menu trying to render on TableSelections.Nov 24 2014, 2:15 AM
Jdforrester-WMF set Security to None.