Page MenuHomePhabricator
Create Task
Maniphest T74841

Configure Rubocop and make it voting for the OOjs UI repo
Closed, ResolvedPublic
Actions

Description

We now have ruby in the OOjs UI repo, so we should enable Rubocop and make sure we're already passing it.

Version: unspecified
Severity: enhancement

Details

Reference
bz72841

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:55 AM
• bzimport added a project: Continuous-Integration-Infrastructure.
• bzimport set Reference to bz72841.
Jdforrester-WMF created this task.Oct 31 2014, 10:57 PM
hashar added a comment.Nov 5 2014, 1:49 PM

I guess Zeljkof can handle it :-)

zeljkofilipin added a comment.Nov 12 2014, 2:03 PM

$ rubocop
Inspecting 3 files
WWC

Offenses:
...
3 files inspected, 718 offenses detected

• bzimport added a comment.Nov 12 2014, 2:15 PM

gerritadmin wrote:

Change 172716 had a related patch set uploaded by Zfilipin:
Prepare repository for RuboCop

https://gerrit.wikimedia.org/r/172716

• bzimport added a comment.Nov 12 2014, 2:25 PM

gerritadmin wrote:

Change 172719 had a related patch set uploaded by Zfilipin:
Fixed whitespace that RuboCop did not ignore

https://gerrit.wikimedia.org/r/172719

• bzimport added a comment.Nov 12 2014, 2:31 PM

gerritadmin wrote:

Change 172722 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/AndOr offense

https://gerrit.wikimedia.org/r/172722

• bzimport added a comment.Nov 12 2014, 2:35 PM

gerritadmin wrote:

Change 172726 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/AsciiComments offense

https://gerrit.wikimedia.org/r/172726

• bzimport added a comment.Nov 12 2014, 2:48 PM

gerritadmin wrote:

Change 172730 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/EmptyLineBetweenDefs offence

https://gerrit.wikimedia.org/r/172730

• bzimport added a comment.Nov 12 2014, 2:48 PM

gerritadmin wrote:

Change 172731 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/EmptyLines offense

https://gerrit.wikimedia.org/r/172731

• bzimport added a comment.Nov 12 2014, 2:49 PM

gerritadmin wrote:

Change 172732 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/NegatedIf offense

https://gerrit.wikimedia.org/r/172732

• bzimport added a comment.Nov 12 2014, 2:49 PM

gerritadmin wrote:

Change 172733 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/SignalException offense

https://gerrit.wikimedia.org/r/172733

• bzimport added a comment.Nov 12 2014, 2:49 PM

gerritadmin wrote:

Change 172734 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/SpaceAroundEqualsInParameterDefault offense

https://gerrit.wikimedia.org/r/172734

• bzimport added a comment.Nov 12 2014, 2:56 PM

gerritadmin wrote:

Change 172738 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/CommentIndentation offense

https://gerrit.wikimedia.org/r/172738

• bzimport added a comment.Nov 12 2014, 2:56 PM

gerritadmin wrote:

Change 172739 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/NilComparison offense

https://gerrit.wikimedia.org/r/172739

• bzimport added a comment.Nov 12 2014, 2:56 PM

gerritadmin wrote:

Change 172740 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/SpaceAfterComma offense

https://gerrit.wikimedia.org/r/172740

• bzimport added a comment.Nov 12 2014, 2:56 PM

gerritadmin wrote:

Change 172741 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/TrailingBlankLines offense

https://gerrit.wikimedia.org/r/172741

• bzimport added a comment.Nov 12 2014, 2:57 PM

gerritadmin wrote:

Change 172742 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/WordArray offense

https://gerrit.wikimedia.org/r/172742

• bzimport added a comment.Nov 17 2014, 1:40 PM

gerritadmin wrote:

Change 172719 abandoned by Zfilipin:
Fixed whitespace that RuboCop did not ignore

https://gerrit.wikimedia.org/r/172719

• bzimport added a comment.Nov 17 2014, 1:41 PM

gerritadmin wrote:

Change 172738 abandoned by Zfilipin:
Fixed RuboCop Style/CommentIndentation offense

https://gerrit.wikimedia.org/r/172738

• bzimport added a comment.Nov 17 2014, 2:05 PM

gerritadmin wrote:

Change 173813 had a related patch set uploaded by Zfilipin:
Prepare oojs/ui repository for RuboCop

https://gerrit.wikimedia.org/r/173813

• bzimport added a comment.Nov 17 2014, 4:26 PM

gerritadmin wrote:

Change 173813 merged by jenkins-bot:
Prepare oojs/ui repository for RuboCop

https://gerrit.wikimedia.org/r/173813

• bzimport added a comment.Nov 17 2014, 9:19 PM

gerritadmin wrote:

Change 172716 merged by jenkins-bot:
Prepare repository for RuboCop

https://gerrit.wikimedia.org/r/172716

• bzimport added a comment.Nov 17 2014, 9:21 PM

gerritadmin wrote:

Change 173939 had a related patch set uploaded by Hashar:
Make oojs-ui-bundle-rubocop voting

https://gerrit.wikimedia.org/r/173939

• bzimport added a comment.Nov 17 2014, 9:25 PM

gerritadmin wrote:

Change 173939 merged by jenkins-bot:
Make oojs-ui-bundle-rubocop voting

https://gerrit.wikimedia.org/r/173939

Jdforrester-WMF added a comment.Nov 18 2014, 3:38 AM

Bug as filed is fixed; outstanding patches are all "make it pass without overrides".

• bzimport added a comment.Nov 18 2014, 11:25 AM

gerritadmin wrote:

Change 172726 merged by Hashar:
Fixed RuboCop Style/AsciiComments offense

https://gerrit.wikimedia.org/r/172726

• bzimport added a comment.Nov 18 2014, 11:25 AM

gerritadmin wrote:

Change 172730 merged by Hashar:
Fixed RuboCop Style/EmptyLineBetweenDefs offence

https://gerrit.wikimedia.org/r/172730

• bzimport added a comment.Nov 18 2014, 11:25 AM

gerritadmin wrote:

Change 172731 merged by Hashar:
Fixed RuboCop Style/EmptyLines offense

https://gerrit.wikimedia.org/r/172731

• bzimport added a comment.Nov 18 2014, 11:25 AM

gerritadmin wrote:

Change 172732 merged by Hashar:
Fixed RuboCop Style/NegatedIf offense

https://gerrit.wikimedia.org/r/172732

• bzimport added a comment.Nov 18 2014, 11:25 AM

gerritadmin wrote:

Change 172733 merged by Hashar:
Fixed RuboCop Style/SignalException offense

https://gerrit.wikimedia.org/r/172733

• bzimport added a comment.Nov 18 2014, 11:25 AM

gerritadmin wrote:

Change 172734 merged by Hashar:
Fixed RuboCop Style/SpaceAroundEqualsInParameterDefault offense

https://gerrit.wikimedia.org/r/172734

• bzimport added a comment.Nov 18 2014, 11:25 AM

gerritadmin wrote:

Change 172739 merged by Hashar:
Fixed RuboCop Style/NilComparison offense

https://gerrit.wikimedia.org/r/172739

• bzimport added a comment.Nov 18 2014, 11:26 AM

gerritadmin wrote:

Change 172740 merged by Hashar:
Fixed RuboCop Style/SpaceAfterComma offense

https://gerrit.wikimedia.org/r/172740

• bzimport added a comment.Nov 18 2014, 11:26 AM

gerritadmin wrote:

Change 172741 merged by Hashar:
Fixed RuboCop Style/TrailingBlankLines offense

https://gerrit.wikimedia.org/r/172741

• bzimport added a comment.Nov 18 2014, 11:26 AM

gerritadmin wrote:

Change 172722 merged by Hashar:
Fixed RuboCop Style/AndOr offense

https://gerrit.wikimedia.org/r/172722

hashar added a comment.Nov 18 2014, 11:48 AM

Patches have been merged in.

• bzimport added a comment.Nov 19 2014, 9:01 AM

gerritadmin wrote:

Change 172742 abandoned by Zfilipin:
Fixed RuboCop Style/WordArray offense

https://gerrit.wikimedia.org/r/172742

hashar moved this task from Untriaged to Done on the Continuous-Integration-Infrastructure board.Feb 28 2015, 2:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL