Page MenuHomePhabricator
Create Task
Maniphest T74951

uselang=user on api breaks in ULS
Closed, ResolvedPublic
Actions

Description

https://en.wikipedia.org/w/api.php?uselang=user gives a error page instead of api help in the user lang. I am not sure, if this bug is in ULS or API.

If you report this error to the Wikimedia System Administrators, please include the details below.

PHP fatal error in /srv/mediawiki/php-1.25wmf5/extensions/UniversalLanguageSelector/UniversalLanguageSelector.hooks.php line 199:
Argument 3 passed to UniversalLanguageSelectorHooks::getLanguage() must be an instance of RequestContext, instance of ApiMain given

Version: master
Severity: normal

Details

Reference
bz72951

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:45 AM
• bzimport added projects: UniversalLanguageSelector, I18n.
• bzimport set Reference to bz72951.
Umherirrender created this task.Nov 4 2014, 3:50 PM
Anomie added a comment.Nov 4 2014, 4:09 PM

It depends on whether the $context parameter to 'UserGetLanguageObject' is really supposed to be a RequestContext, or if any IContextSource implementation should be accepted. If the former, API; if the latter, ULS and docs/hooks.txt.

I note that ULS only uses it for $context->getRequest(), so any IContextSource would do. And CentralAuth is also calling the hook while passing something that is only guaranteed to be an IContextSource (specifically whatever is returned by SpecialPage::getContext()).

gerritbot added a comment.Nov 4 2014, 4:25 PM

Change 170938 had a related patch set uploaded by Anomie:
UserGetLanguageObject hook should accept any IContextSource

https://gerrit.wikimedia.org/r/170938

gerritbot added a comment.Nov 4 2014, 4:28 PM

Change 170940 had a related patch set uploaded by Anomie:
UserGetLanguageObject hook should accept any IContextSource

https://gerrit.wikimedia.org/r/170940

gerritbot added a comment.Nov 4 2014, 4:32 PM

Change 170938 merged by jenkins-bot:
UserGetLanguageObject hook should accept any IContextSource

https://gerrit.wikimedia.org/r/170938

gerritbot added a comment.Nov 4 2014, 4:34 PM

Change 170944 had a related patch set uploaded by Anomie:
UserGetLanguageObject hook should accept any IContextSource

https://gerrit.wikimedia.org/r/170944

gerritbot added a comment.Nov 4 2014, 4:35 PM

Change 170945 had a related patch set uploaded by Anomie:
UserGetLanguageObject hook should accept any IContextSource

https://gerrit.wikimedia.org/r/170945

gerritbot added a comment.Nov 4 2014, 4:39 PM

Change 170944 merged by jenkins-bot:
UserGetLanguageObject hook should accept any IContextSource

https://gerrit.wikimedia.org/r/170944

gerritbot added a comment.Nov 4 2014, 4:39 PM

Change 170945 merged by jenkins-bot:
UserGetLanguageObject hook should accept any IContextSource

https://gerrit.wikimedia.org/r/170945

Anomie added a comment.Nov 4 2014, 4:48 PM

The bug itself is fixed, and was backported during the SWAT window that was conveniently still open. The doc fix for hooks.txt is still outstanding, but that's just bug 1.

gerritbot added a comment.Nov 4 2014, 5:17 PM

Change 170940 merged by jenkins-bot:
UserGetLanguageObject hook should accept any IContextSource

https://gerrit.wikimedia.org/r/170940

Aklapper removed subscribers: Anomie, • Jsahleen.Oct 16 2020, 5:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL