Page MenuHomePhabricator

Exception during Siteinfo can cause it to enter incorrect state
Closed, ResolvedPublic

Description

I've seen this occur a few times locally while in the shell, but not on travis previously.

https://travis-ci.org/wikimedia/pywikibot-core/jobs/40263585

test_direct_non_local fails during siteinfo , but then the site object is reused for test_indirect_non_local and it doesnt try again.

In my local testing, I can cause this to happen by pressing ^C during Site.namespaces, and then using the site object again.


Version: core-(2.0)
Severity: minor

Details

Reference
bz73122

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:56 AM
bzimport set Reference to bz73122.
bzimport added a subscriber: Unknown Object (????).

gerritadmin wrote:

Change 171815 had a related patch set uploaded by XZise:
[FIX] Site: Only store complete mapping

https://gerrit.wikimedia.org/r/171815

gerritadmin wrote:

Change 171815 merged by jenkins-bot:
[FIX] Site: Only store complete mapping

https://gerrit.wikimedia.org/r/171815

All patches mentioned in this report were merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?