Page MenuHomePhabricator

Do not update entity cache on null-edits
Closed, InvalidPublic

Description

When saving an entity without changing it, the MediaWiki storage layer (WikiPage) will not create a new revision (it performs a "null edit"). However, WikiPageEntityStore::saveEntity will still signal an 'entityUpdated' event to listeners, which causes CachingEntityRevisionLookup to push the new version of the entity (which should be the same as the old) into the cache.

If null edits only happen when they should, this should not be a problem - it would just cause a bit of unnecessary memcached traffic for null edits. However, in case of "accidental" null-edits caused by false positives reported by EntityContent::equals, caching the new (actually different) version of the entity even though it did not get save to the database adds to the confusion.


Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=0
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=73258

Details

Reference
bz73257

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:48 AM
bzimport set Reference to bz73257.
bzimport added a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).

Closing since we didn't get to it in over two years.