Page MenuHomePhabricator
Create Task
Maniphest T75283

ImportTest::testHandlePageContainsRedirect causes MWException: Cannot create InputStreamSource
Closed, ResolvedPublic
Actions

Description

  1. ImportTest::testHandlePageContainsRedirect with data set #1 ('<mediawiki xmlns="http://www.mediawiki.org/xml/export-0.9/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.mediawiki.org/xml/export-0.9/ http://www.mediawiki.org/xml/export-0.9.xsd" version="0.9" xml:lang="en"> <page> <title>Test</title> <ns>0</ns> <id>42</id> <revision> <id>421</id> <timestamp>2014-05-27T11:00:00Z</timestamp> <contributor> <username>Admin</username> <id>10</id> </contributor> <text xml:space="preserve" bytes="4">Abcd</text> <sha1>n7uomjq96szt60fy5w3x7ahf7q8m8rh</sha1> <model>wikitext</model> <format>text/x-wiki</format> </revision> </page>

</mediawiki>', NULL)
MWException: Cannot create InputStreamSource.

/usr/home/saper/public_html/pg/w/tests/phpunit/includes/ImportTest.php:16
/usr/home/saper/public_html/pg/w/tests/phpunit/includes/ImportTest.php:28
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestCase.php:976
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestCase.php:831
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestResult.php:648
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestCase.php:776
/usr/home/saper/public_html/pg/w/tests/phpunit/MediaWikiTestCase.php:141
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestSuite.php:775
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestSuite.php:745
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestSuite.php:705
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestSuite.php:705
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestSuite.php:705
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/TextUI/TestRunner.php:349
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/TextUI/Command.php:176
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/TextUI/Command.php:129
/usr/share/php/phpunit/phpunit.phar:531

May be related to bug 72214, but that's a different message

Version: 1.25-git
Severity: normal

Details

Reference
bz73283
SubjectRepoBranchLines +/-
Use ImportStringSource for simple import sourcesmediawiki/coremaster+4 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:49 AM
• bzimport added a project: MediaWiki-Core-Tests.
• bzimport set Reference to bz73283.
• bzimport added a subscriber: Unknown Object (MLST).
saper created this task.Nov 11 2014, 10:05 PM
saper added a comment.Nov 11 2014, 10:18 PM

Simple smoke test is failing here (need to have gerrit change 156446 installed to use print not print_r):

print ImportStreamSource::newFromFile('data:application/xml,<xml><p>Hi</p></xml>');

<Error, collected 1 error(s) on the way, no value set>
+------+---------------------------+------------------------------------------+

1importcantopen

+------+---------------------------+------------------------------------------+

saper added a comment.Nov 11 2014, 10:39 PM

So this was caused by gerrit change 134079 which introduced "Import Testing".

This little thing now requires the use of fopen() with stream wrappers, data URL and .... "allow_url_open" set to "On"

Do we require allow_url_open to be enabled now?

It seems to be an overkill for some simple thing like providing a test string to an XML parser.

But here I think a monster thing called includes/Import.php is to blame

• bzimport added a comment.Nov 11 2014, 10:54 PM

gerritadmin wrote:

Change 172657 had a related patch set uploaded by saper:
Skip ImportTest if allow_url_fopen disabled

https://gerrit.wikimedia.org/r/172657

• bzimport added a comment.Nov 14 2014, 12:58 AM

gerritadmin wrote:

Change 173222 had a related patch set uploaded by saper:
Use ImportStringSource for simple import sources

https://gerrit.wikimedia.org/r/173222

• bzimport added a comment.Nov 14 2014, 12:59 AM

gerritadmin wrote:

Change 173222 abandoned by saper:
Use ImportStringSource for simple import sources

Reason:
Wrongly submitted

https://gerrit.wikimedia.org/r/173222

• bzimport added a comment.Nov 14 2014, 1:01 AM

gerritadmin wrote:

Change 173223 had a related patch set uploaded by saper:
Use ImportStringSource for simple import sources

https://gerrit.wikimedia.org/r/173223

gerritbot added a comment.Dec 31 2014, 1:18 AM

Change 182333 had a related patch set uploaded (by McIntireEvan):
Documented the Class ImportStringSource based on https://phabricator.wikimedia.org/T75283

https://gerrit.wikimedia.org/r/182333

Patch-For-Review

gerritbot subscribed.Sep 24 2015, 12:47 PM

Change 172657 merged by jenkins-bot:
Skip ImportTest if allow_url_fopen disabled

https://gerrit.wikimedia.org/r/172657

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2015, 12:47 PM
gerritbot added a comment.Oct 22 2015, 9:27 PM

Change 173223 had a related patch set uploaded (by saper):
Use ImportStringSource for simple import sources

https://gerrit.wikimedia.org/r/173223

gerritbot added a comment.Oct 27 2015, 3:15 PM

Change 173223 merged by jenkins-bot:
Use ImportStringSource for simple import sources

https://gerrit.wikimedia.org/r/173223

daniel added a comment.Oct 27 2015, 3:40 PM

Patch is merged. Please verify that this fixes the issue, and close the ticket if it does.

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)).Oct 27 2015, 4:00 PM
saper added a parent task: T116704: MediaWiki CI tests should run with allow_url_fopen set to false.Oct 27 2015, 6:01 PM
Liuxinyu970226 set Security to None.Dec 20 2015, 12:33 AM
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jul 7 2017, 5:14 AM
Umherirrender closed this task as Resolved.Apr 2 2022, 8:37 PM
Umherirrender removed a project: Patch-For-Review.
Umherirrender removed a subscriber: • wikibugs-l-list.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL