Page MenuHomePhabricator

VisualEditor: Link inspector does not function correctly after closing it using "Done"/"Remove" button in Firefox while the cursor is never active on CE
Closed, ResolvedPublic1 Estimated Story Points

Description

edit a page on beta labs e.g. http://en.wikipedia.beta.wmflabs.org/wiki/Media_Interface_VisualEditor_Test?veaction=edit

Click the Link inspector. Note the local link created.

Click Remove.

Click the Link inspector again.

See an entirely different UI showing "New page/Matching pages"

Click in the ContentEditable part. "New page/Matching pages" UI disappears.

Click the Link inspector again.

Nothing happens. Link inspector stops working completely.


Version: unspecified
Severity: normal

Details

Reference
bz73423

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:58 AM
bzimport set Reference to bz73423.

Note: this behavior is seen in Firefox. Chrome seems to be OK.

On http://en.wikipedia.beta.wmflabs.org/wiki/Media_Interface_VisualEditor_Test?veaction=edit - the link was applied to a specific word(s)?

I tried to follow your scenario with the word Test on that page - "New page/Matching pages" seems to be identical with any attempts.

I cannot reproduce this issue following these steps either.

Created attachment 17124
after invoking Link inspector the first time, before clicking Remove

Attached:

link_before_clicking_remove_first_time.png (1×1 px, 220 KB)

Created attachment 17125
after clicking Remove and then clicking Link inspector again

This is clearly wrong

Attached:

after_clicking_link_second_time.png (1×1 px, 314 KB)

Created attachment 17126
clicking Link no longer invokes the Link inspector at all

Attached:

link_inspector_does_not_appear_when_invoked.png (1×1 px, 265 KB)

FWIW, I can repro this consistently in Firefox 32.0.3

Steps to reproduce:

1.Go to this page:http://en.wikipedia.beta.wmflabs.org/wiki/Media_Interface_VisualEditor_Test?veaction=edit

2.Click on link inspector icon from the toolbar , but make sure you do not place your cursor in the article first

3.Once the link inspector opens for the first text "Media" , click on "Done" or "Remove" to close the link inspector.Again, do not place the cursor inside CE

4.Click on link inspector icon from the toolbar again

At this step, you will see a broken UI for link inspector,just the link suggestions are appearing as the screenshot.

Also, after this step link inspector stops working completely, clicking on the link icon from the toolbar does not open link inspector for any other text in the article .

Environment:betalabs,test2, en.wiki

Also, happens when you type a text and select that and try to open link inspector for it

Ryasmeen triaged this task as Medium priority.Jan 15 2015, 2:34 AM
Ryasmeen moved this task from To Triage to Freezer on the VisualEditor board.
Ryasmeen set Security to None.
Jdforrester-WMF claimed this task.

This looks like it was fixed a while ago.