Page MenuHomePhabricator
Create Task
Maniphest T75430

VisualEditor: Non-numeric colspan/rowspan values are normalized, or corrupted to NaN
Closed, ResolvedPublic
Actions

Description

See e.g. https://fr.wikipedia.org/?diff=109114947

Version: unspecified
Severity: major

Details

Reference
bz73430

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:58 AM
• bzimport added projects: VE-deploy-2014-11-19 (1.25wmf9), VisualEditor-DataModel.
• bzimport set Reference to bz73430.
Catrope created this task.Nov 14 2014, 7:59 PM
gerritbot added a comment.Nov 14 2014, 9:05 PM

Change 173363 had a related patch set uploaded by Catrope:
Restore original rowspan/colspan rather than normalizing or overwriting with NaN

https://gerrit.wikimedia.org/r/173363

Catrope added a comment.Nov 14 2014, 9:07 PM

It turned out there were two corruption problems: colspan="02" was normalized to colspan="2", and colspan="2 garbage" was normalized to colspan="NaN". The patch fixes both.

gerritbot added a comment.Nov 14 2014, 10:37 PM

Change 173363 merged by jenkins-bot:
Restore original rowspan/colspan rather than normalizing or overwriting with NaN

https://gerrit.wikimedia.org/r/173363

Jdforrester-WMF added a comment.Nov 14 2014, 11:00 PM

To go out in Monday's SWAT.

Etonkovidova added a comment.Nov 14 2014, 11:59 PM

Verified the fix in beta.

Etonkovidova added a comment.Nov 20 2014, 12:31 AM

Verified the fix in test2.

Etonkovidova added a project: Verified-in-Phase2.Nov 27 2014, 12:34 AM
Etonkovidova set Security to None.
Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 1:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL