Config option for target should default to empty or _self, not _blank.
Version: unspecified
Severity: normal
Description
Description
Details
Details
- Reference
- bz73452
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| [BREAKING CHANGE] ButtonWidget: Don't default 'target' to '_blank' | oojs/ui | master | +2 -7 |
Related Objects
Related Objects
Event Timeline
Comment Actions
richhiey.thomas wrote:
Changed the config for target to '_self'. Is this okay?
Attached:
Comment Actions
(In reply to Richhiey from comment #1)
Created attachment 17148 [details]
Changed the config for target to '_self'. Is this okay?
That looks good; do you want to submit that for code review as a patch?
https://www.mediawiki.org/wiki/Gerrit/Tutorial has instructions if you've not done this before.
Attached:
Comment Actions
Change 176488 had a related patch set uploaded (by Bartosz Dziewoński):
[BREAKING CHANGE] ButtonWidget: Don't default 'target' to '_blank'
Comment Actions
As far as I can tell, this "breaking change" doesn't actually break any of the code I know of. Seems that nobody uses the href config parameter for ButtonWidget at all (other than our own OOUI demo).
Comment Actions
Change 176488 merged by jenkins-bot:
[BREAKING CHANGE] ButtonWidget: Don't default 'target' to '_blank'