Page MenuHomePhabricator

Selecting huge chunks of text with Shift + arrow up/down is broken or works inconsistently
Open, MediumPublic

Description

See video made by de.wp user:Gnom: https://www.youtube.com/watch?v=Dm_WyFfMC1M

"Trying to mark a big chunk of text in a Wikipedia article using Visual Editor, first with the shift and arrow keys, then with the mouse and a trackwheel, then with both combined. Windows 7 HP SP 1, Chrome 38.0.2125.122 m, Vector, 17 November 2014."

I tested quickly with Chrome and FF.
On the first one, while pressing Shift + arrow down, the selection works until I get to the last line I'm seeing on my screen, but the view doesn't scroll further down, so the action might still be working, but I just am not able to know it. (Shift + arrow up, from the bottom of the page, seems to work better instead).
But, depending on the speed you hit Down, it might lose some of the selection.

On FF instead instead the selection just stops working after the 3rd time or so you click on the up or down arrows.

In both the browsers, clicking at the beginning of the article, holding Shift, then scrolling all the way down to the end dragging the right scrollbar with the mouse and clicking again after the last word at the bottom worked just fine (also the other way around, from bottom to top).
I wouldn't know about other combinations such as Shift + Page Up/Down because I'm not entirely show of what should be the expected outcome there.


Version: unspecified
Severity: normal

Details

Reference
bz73512

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:48 AM
bzimport added a project: VisualEditor.
bzimport set Reference to bz73512.

*after the 3rd time or so you /hit/ the up or down arrows.

*I'm not entirely /sure/ of what should be the expected outcome there.

The same issue with IE11 on Windows8 - along with Chrome/FF there: while highlighting the text with Shift+arrows, the page does not scroll down when the highlighting reaches the last line displayed on the page.

On https://de.wikipedia.org/w/index.php?title=Arbeitsrecht_(Deutschland)&action=edit, it's not possible to highlight several paragraph with arrow buttons. For example, there is a paragraph:

Dadurch war die Rätebewegung, die unter dem Schlagwort 'Alle Macht den [[Arbeiter- und Soldatenrat|Räten]]' die politische und wirtschaftliche Macht im Staat gefordert hatte, in eine wirtschaftliche Interessenvertretung umgewandelt und in die Wirtschaftsverfassung eingebaut worden. Da den [[Gewerkschaft]]en aber die Kompetenz zur Vereinbarung der Lohn- und Arbeitsbedingungen verfassungsrechtlich garantiert wurde, waren die Arbeiterräte in einem Kernbereich des Arbeitsrechts an den Rand gedrängt. Von dem dreistufigen Rätesystem wurde außerdem nur die unterste Stufe durch das Betriebsrätegesetz vom 4. Februar 1920 verwirklicht.“<ref name="Richardi, S. 15"/>

which is rendered:

<p class="ve-ce-paragraphNode ve-ce-branchNode">Dadurch war die Rätebewegung, die unter dem Schlagwort 'Alle Macht den <a rel="mw:WikiLink" href="http://en.wikipedia.beta.wmflabs.org/wiki/Arbeiter-_und_Soldatenrat" title="Arbeiter- und Soldatenrat" class="ve-ce-linkAnnotation ve-ce-mwInternalLinkAnnotation">Räten</a>' die politische und wirtschaftliche Macht im Staat gefordert hatte, in eine wirtschaftliche Interessenvertretung umgewandelt und in die Wirtschaftsverfassung eingebaut worden. Da den <a rel="mw:WikiLink" href="http://en.wikipedia.beta.wmflabs.org/wiki/Gewerkschaft" title="Gewerkschaft" class="ve-ce-linkAnnotation ve-ce-mwInternalLinkAnnotation">Gewerkschaften</a> aber die Kompetenz zur Vereinbarung der Lohn- und Arbeitsbedingungen verfassungsrechtlich garantiert wurde, waren die Arbeiterräte in einem Kernbereich des Arbeitsrechts an den Rand gedrängt. Von dem dreistufigen Rätesystem wurde außerdem nur die unterste Stufe durch das Betriebsrätegesetz vom 4. Februar 1920 verwirklicht.“<span about="#mwt2" class="reference ve-ce-leafNode ve-ce-mwReferenceNode ve-ce-focusableNode" id="cite_ref-Richardi.2C_S._15_1-0" rel="dc:references" typeof="mw:Extension/ref" contenteditable="false"><a href="#">[1]</a></span><span class="ve-ce-branchNode-slug ve-ce-branchNode-inlineSlug"><img src="data:image/gif;base64,R0lGODdhAQABAADcACwAAAAAAQABAAA" class="ve-ce-chimera" style="width: 0px; height: 0px;"></span></p>

The culprit seems to be <ref name="Richardi, S. 15"/>.

Etonkovidova set Security to None.

A slightly different behaviour, which may be caused by the same underlying problem (just copying my note from en-Wiki):

Selecting text with "Shift + Arrow down" and "Shift + Left Mouse button" is interrupted sometimes. Take [[Hockenheim]] on en-Wiki for example, and try to select a text starting at the beginning of the "Town Structure" line down to "History" and further down:
*With "Shift + Arrow down" the selection stops immediately at "Town Structure", I can't select further text.
*With "Shift + Left Mouse Button" further selection is possible, but it then stops at "History". If I try to select more text, the text before "History" and the "History" header is de-selected while I can select further text.

Note: this happens ''only'' with headers immediately followed by an image. The same function works OK around the "International relations" header further down (with no image nearby).
System specs: Windows XP, FF 40.0.3, Vector skin, desktop version.