Page MenuHomePhabricator
Create Task
Maniphest T75521

Jenkins: Implement hhvm based voting jobs for mediawiki and extensions
Closed, ResolvedPublic
Actions

Description

With more and more traffic being served by hhvm backends, it feels prudent to make passing the hhvm test suites a prerequisite for merging.

As they currently fail (cf. https://integration.wikimedia.org/ci/job/mediawiki-core-regression-hhvm-master/2649/console), fixing those failures is a blocker for this bug.

Details

Reference
bz73521
SubjectRepoBranchLines +/-
Make mediawiki-core-regression-hhvm-master votingintegration/configmaster+0 -1
Make mediawiki-phpunit-hhvm voting!!!11!!BBQ!!integration/configmaster+0 -3
Suffix mediawiki-phpunit with '-zend' + enable hhvmintegration/configmaster+14 -8
zuul: suffix mw testextension jobs with '-zend'integration/configmaster+12 -6
Support MediaWiki PHP tests under HHVMintegration/configmaster+129 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:49 AM
• bzimport added a project: Continuous-Integration-Infrastructure.
• bzimport set Reference to bz73521.
• bzimport added a subscriber: Unknown Object (MLST).
scfc created this task.Nov 17 2014, 6:32 PM
hashar added a comment.Nov 17 2014, 8:04 PM

I will add another non voting job that runs the phpunit test suite using HHVM. I found out last week that our Trusty instances have /usr/bin/php pointing to HHVM so that is fairly easy to copy paste the job :]

hashar added a comment.Nov 17 2014, 8:17 PM

Bah the Trusty slaves are back to Zend php. So either we can:

A) set the alternative to have /usr/bin/php point to /usr/bin/hhvm

B) update all jobs and scripts to replace php by something like $PHP_FLAVOR which we could pass when triggering the job.

Seems the first is way easier.

hashar added a comment.Nov 17 2014, 8:29 PM

Adding a couple dependencies that are blocking HHVM on CI slaves:

bug 71413 [OPS] hhvm 3.3.0-20140925+wmf3 has some annoying build dependency
bug 73356 CI Trusty slaves no more have hhvm installed

bd808 triaged this task as High priority.Nov 26 2014, 7:11 PM
bd808 added a project: HHVM.
bd808 subscribed.

The HHVM migration has progressed to the point that we are not longer distinguishing between PHP5 and HHVM servers in the app server pool. The last report I heard based on instance count was that 34% of requests were being served by HHVM.

scfc closed subtask T75531: ApiFormatWddxTest::testValidSyntax fails in mediawiki-core-regression-hhvm-master test as Resolved.Nov 26 2014, 11:53 PM
hashar added a comment.Dec 1 2014, 5:08 PM

The main stopper is having hhvm installed and properly configured which is T75356: [OPS] Jenkins: Slaves running Ubuntu Trusty should have hhvm installed.

gerritbot added a project: Patch-For-Review.Dec 10 2014, 4:26 PM

Change 178862 had a related patch set uploaded (by Hashar):
Support MediaWiki core under HHVM

https://gerrit.wikimedia.org/r/178862

Patch-For-Review

hashar reopened subtask T75531: ApiFormatWddxTest::testValidSyntax fails in mediawiki-core-regression-hhvm-master test as Open.Dec 10 2014, 5:35 PM
hashar added a subtask: T78166: MediaWiki tests using Tidy do not pass on HHVM.Dec 10 2014, 5:43 PM
hashar closed subtask T78166: MediaWiki tests using Tidy do not pass on HHVM as Resolved.Dec 10 2014, 8:46 PM
gerritbot added a comment.Dec 15 2014, 11:07 AM

Change 178862 merged by jenkins-bot:
Support MediaWiki PHP tests under HHVM

https://gerrit.wikimedia.org/r/178862

gerritbot added a comment.Dec 15 2014, 4:24 PM

Change 179946 had a related patch set uploaded (by Hashar):
zuul: suffix mw testextension jobs with '-zend'

https://gerrit.wikimedia.org/r/179946

Patch-For-Review

gerritbot added a comment.Dec 15 2014, 4:27 PM

Change 179946 merged by jenkins-bot:
zuul: suffix mw testextension jobs with '-zend'

https://gerrit.wikimedia.org/r/179946

gerritbot added a comment.Dec 15 2014, 4:47 PM

Change 179951 had a related patch set uploaded (by Hashar):
Suffix mediawiki-phpunit with '-zend' enable hhvm

https://gerrit.wikimedia.org/r/179951

Patch-For-Review

gerritbot added a comment.Dec 15 2014, 4:52 PM

Change 179951 merged by jenkins-bot:
Suffix mediawiki-phpunit with '-zend' enable hhvm

https://gerrit.wikimedia.org/r/179951

hashar renamed this task from Jenkins: Implement mediawiki-phpunit-hhvm job for mediawiki-core repo (and voting) to Jenkins: Implement hhvm based voting jobs for mediawiki and extensions.Dec 15 2014, 8:43 PM
hashar renamed this task from Jenkins: Implement hhvm based voting jobs for mediawiki and extensions to Jenkins: Implement hhvm based voting jobs for mediawiki and extensions (tracking).
hashar claimed this task.
hashar moved this task from Untriaged to In-progress on the Continuous-Integration-Infrastructure board.
hashar added a subtask: T78592: EchoTitleLocalCacheTest::testGet fails when tests are run with other extensions.
hashar set Security to None.

I have made it a tracking bug and widened scope to MediaWiki extensions as well.

hashar closed subtask T78556: hhvm on CI slaves can not find PEAR.php as Resolved.Dec 16 2014, 1:22 PM
hashar added a project: Release-Engineering-Team.Dec 16 2014, 5:08 PM

+ RelEng project to make this task appear on our team work board.

hashar moved this task from INBOX to In-progress on the Release-Engineering-Team board.Dec 16 2014, 5:09 PM
hashar added a subtask: T78680: EventLogging ValidateSchemaTest::testValidEvent() fails under HHVM.Dec 16 2014, 5:27 PM
gerritbot added a comment.Dec 18 2014, 5:01 PM

Change 180815 had a related patch set uploaded (by Hashar):
Make mediawiki-phpunit-hhvm voting!11BBQ!!

https://gerrit.wikimedia.org/r/180815

Patch-For-Review

gerritbot added a comment.Dec 18 2014, 5:07 PM

Change 180815 merged by jenkins-bot:
Make mediawiki-phpunit-hhvm voting!11BBQ!!

https://gerrit.wikimedia.org/r/180815

gerritbot added a comment.Dec 18 2014, 5:17 PM

Change 180820 had a related patch set uploaded (by Hashar):
Make mediawiki-core-regression-hhvm-master voting

https://gerrit.wikimedia.org/r/180820

Patch-For-Review

gerritbot added a comment.Dec 18 2014, 5:19 PM

Change 180820 merged by jenkins-bot:
Make mediawiki-core-regression-hhvm-master voting

https://gerrit.wikimedia.org/r/180820

hashar added a comment.Dec 18 2014, 5:22 PM

mediawiki-core now has a HHVM based job that is voting.

Next step are the extensions which is a different beast.

hashar closed subtask T75531: ApiFormatWddxTest::testValidSyntax fails in mediawiki-core-regression-hhvm-master test as Resolved.Dec 19 2014, 5:06 PM
Amire80 added a subtask: T85124: UniversalLanguageSelector patches are blocked by voting schema tests.Dec 22 2014, 8:07 AM
QChris closed subtask T78680: EventLogging ValidateSchemaTest::testValidEvent() fails under HHVM as Resolved.Dec 22 2014, 8:54 AM
hashar removed a subtask: T85124: UniversalLanguageSelector patches are blocked by voting schema tests.Dec 22 2014, 9:57 AM
hashar closed subtask T73413: [OPS] hhvm 3.3.0-20140925+wmf3 has some annoying build dependency as Resolved.Dec 22 2014, 9:11 PM
hashar mentioned this in rCICF705ba6959e92: Support MediaWiki PHP tests under HHVM.Dec 31 2014, 6:27 PM
hashar mentioned this in rCICFc6958a6f0f2a: zuul: suffix mw testextension jobs with '-zend'.
hashar mentioned this in rCICF129c2489d654: Suffix mediawiki-phpunit with '-zend' + enable hhvm.
hashar mentioned this in rCICFe510c54ffe9e: Make mediawiki-phpunit-hhvm voting!!!11!!BBQ!!.
hashar mentioned this in rCICF5ab299373b48: Make mediawiki-core-regression-hhvm-master voting.
hashar closed subtask T78592: EchoTitleLocalCacheTest::testGet fails when tests are run with other extensions as Resolved.Jan 6 2015, 1:40 PM
hashar closed subtask T75356: [OPS] Jenkins: Slaves running Ubuntu Trusty should have hhvm installed as Resolved.Jan 8 2015, 10:08 AM
hashar reopened subtask T78592: EchoTitleLocalCacheTest::testGet fails when tests are run with other extensions as Open.Jan 8 2015, 10:10 AM
faidon mentioned this in rOPUPd55e0e5d837d: contint: provision hhvm on CI slaves.Jan 9 2015, 10:37 AM
hashar closed subtask T78592: EchoTitleLocalCacheTest::testGet fails when tests are run with other extensions as Resolved.Jan 9 2015, 3:33 PM
hashar added a parent task: T69216: Have unit tests of all wmf deployed extensions pass when installed together, in both PHP-Zend and HHVM (tracking).Jan 16 2015, 11:14 AM
hashar added a comment.Jan 16 2015, 11:17 AM

The hhvm job is voting for mediawiki/core mediawiki/vendor.

Some selected extensions have voting hhvm tests via a job shared between a subset of extensions. See my Jan 12 announcement on wikitech-l.

Krinkle reopened subtask T78592: EchoTitleLocalCacheTest::testGet fails when tests are run with other extensions as Open.Jan 29 2015, 11:48 PM
Krinkle closed subtask T78592: EchoTitleLocalCacheTest::testGet fails when tests are run with other extensions as Resolved.Jan 30 2015, 12:51 AM
Krinkle reopened subtask T78592: EchoTitleLocalCacheTest::testGet fails when tests are run with other extensions as Open.
• Mattflaschen-WMF closed subtask T78592: EchoTitleLocalCacheTest::testGet fails when tests are run with other extensions as Resolved.Jan 30 2015, 12:59 AM
JanZerebecki subscribed.Feb 26 2015, 11:54 AM
hashar added a subtask: T101392: Trigger PHPUnit job for MediaWiki extensions with HHVM instead of Zend in 'test' pipeline.Jun 9 2015, 2:36 PM
hashar edited projects, added Continuous-Integration-Config; removed Continuous-Integration-Infrastructure.

Need to do child task T101392 which is to add the -hhvm jobs to all extensions.

hashar moved this task from In-progress to Backlog (ARCHIVED) on the Release-Engineering-Team board.Jun 9 2015, 3:20 PM
JanZerebecki added a subtask: T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma).Jun 22 2015, 2:10 PM
hashar removed a project: Patch-For-Review.Aug 24 2015, 2:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2015, 2:04 PM
greg removed hashar as the assignee of this task.Sep 24 2015, 1:18 AM
greg updated the task description. (Show Details)
greg edited projects, added Release-Engineering-Epics; removed Release-Engineering-Team.
Legoktm closed subtask T101392: Trigger PHPUnit job for MediaWiki extensions with HHVM instead of Zend in 'test' pipeline as Resolved.Feb 10 2016, 8:46 AM
Legoktm closed this task as Resolved.Feb 10 2016, 8:48 AM
Legoktm claimed this task.
Legoktm subscribed.

This happened as part of the php55 version bump.

Legoktm removed Legoktm as the assignee of this task.Feb 10 2016, 8:49 AM
Catrope closed subtask T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma) as Resolved.Feb 13 2016, 12:29 AM
JanZerebecki reopened subtask T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma) as Open.Feb 13 2016, 9:56 AM
greg edited projects, added Release-Engineering-Team; removed Release-Engineering-Epics.Mar 11 2016, 10:11 PM
Danny_B added a project: Tracking-Neverending.May 5 2016, 7:29 PM
Danny_B moved this task from Tag to Should be Goal instead on the Tracking-Neverending board.Jul 11 2016, 2:57 PM
• Phabricator_maintenance added a project: Goal.Aug 13 2016, 8:41 PM
• Phabricator_maintenance removed a subscriber: • wikibugs-l-list.
• Phabricator_maintenance renamed this task from Jenkins: Implement hhvm based voting jobs for mediawiki and extensions (tracking) to Jenkins: Implement hhvm based voting jobs for mediawiki and extensions.Aug 13 2016, 9:38 PM
• Phabricator_maintenance removed a project: Tracking-Neverending.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL