Page MenuHomePhabricator

expand_text fails for empty page
Closed, ResolvedPublic

Description

API action expandtemplates requires a value for the text param

https://en.wikipedia.org/w/api.php?action=expandtemplates&text=

{

"servedby": "mw1032",
"error": {
    "code": "notext",
    "info": "The text parameter must be set",
    "*": "See https://en.wikipedia.org/w/api.php for API usage"
}

}

This causes a failure running the tests on wikia

page_tests.TestPageObject.testLinks

Traceback (most recent call last):

File "./tests/page_tests.py", line 461, in testLinks
  iw = list(mainpage.interwiki(expand=True))
File "./pywikibot/page.py", line 1150, in interwiki
  text = self.expand_text()
File "./pywikibot/tools.py", line 647, in wrapper
  return obj(*__args, **__kw)
File "./pywikibot/page.py", line 499, in expand_text
  includecomments=includecomments)
File "./pywikibot/site.py", line 992, in callee
  return fn(self, *args, **kwargs)
File "./pywikibot/site.py", line 1958, in expand_text
  return req.submit()['expandtemplates'][key]
File "./pywikibot/data/api.py", line 1213, in submit
  self._data = super(CachedRequest, self).submit()
File "./pywikibot/data/api.py", line 1071, in submit
  raise APIError(code, info, **result["error"])

pywikibot.data.api.APIError: notext: The text parameter must be set

This happens because the Wikia homepage is an empty page

http://www.wikia.com/Wikia?action=edit
http://www.wikia.com/api.php?format=jsonfm&action=query&titles=Wikia&prop=info|revisions&rvprop=ids|flags|content


Version: core-(2.0)
Severity: normal

Details

Reference
bz73529

Related Objects

StatusSubtypeAssignedTask
Resolvedjayvdb
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:49 AM
bzimport set Reference to bz73529.
bzimport added a subscriber: Unknown Object (????).

Change 173994 had a related patch set uploaded by John Vandenberg:
Skip expandtemplates if the page content is empty

https://gerrit.wikimedia.org/r/173994

Change 173994 merged by jenkins-bot:
Skip expandtemplates if the page content is empty

https://gerrit.wikimedia.org/r/173994

For context re Wikia, they use WikiaHomePage extension, and the 'mainpage' (Wikia) page is indeed empty.
http://www.wikia.com/api.php?action=query&titles=Wikia&prop=info|revisions
http://www.wikia.com/api.php?action=query&meta=siteinfo

(perhaps it is worth exploring whether 'empty page' is such an anomaly that it should be an exception like NoPage or IsRedirect)

jayvdb edited subscribers, added: XZise; removed: Unknown Object (????).