Page MenuHomePhabricator
Create Task
Maniphest T75562

Wikibase's undo edit form does not add the hidden wpUndidRevision field
Closed, ResolvedPublic
Actions

Description

Currently a user does not get notified when they are reverted on Wikidata. The reason might be the different content model on item pages there?

Version: master
Severity: normal

Details

Reference
bz73562

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:51 AM
• bzimport added a project: MediaWiki-extensions-WikibaseRepository.
• bzimport set Reference to bz73562.
Lydia_Pintscher created this task.Nov 18 2014, 4:36 PM
Legoktm added a comment.Nov 18 2014, 6:04 PM

When I visit https://www.wikidata.org/w/index.php?title=Q4115189&action=edit&undoafter=175070004&undo=175078243, there is no hidden wpUndidRevision form field which Echo is looking for.

It's added by EditPage: https://github.com/wikimedia/mediawiki/blob/1766e1cd92e5b333b4a2b67ee37e90094415c47c/includes/EditPage.php#L2419

gerritbot added a comment.Nov 18 2014, 9:25 PM

Change 174283 had a related patch set uploaded by Legoktm:
Set "wpUndidRevision" hidden field in EntityAction

https://gerrit.wikimedia.org/r/174283

Legoktm closed this task as Resolved.Nov 24 2014, 2:45 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL