Page MenuHomePhabricator

GeSHi version constant defined twice
Closed, ResolvedPublic

Description

The following commit has created a situation where the GeSHi version constant is defined twice, resulting in a notice.

https://gerrit.wikimedia.org/r/#/c/172581/

This commit needs to be reverted or fixed.


Version: master
Severity: normal

Details

Reference
bz73567

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:51 AM
bzimport added a project: SyntaxHighlight.
bzimport set Reference to bz73567.
bzimport added a subscriber: Unknown Object (MLST).

I believe this bug is causing a failure on all Wikipedias in beta-labs. Anything that uses EventLogging is bitten by this bug because EventLogging depends on the SyntaxHighlighting_GeSHi extension. In my dev environment, having EventLogging and GeSHi enabled causes pages to load with a notice that the version constant is defined twice. On beta-labs you just get a white page. I'm not 100% sure the beta outage is caused by this bug but it seems highly likely.

(In reply to Joel Sahleen from comment #1)

I believe this bug is causing a failure on all Wikipedias in beta-labs.

Might be one potential reason, might not. From SRE:
<_joe_> marktraceur: it needs a restart, and maybe some tuning
<marktraceur> /var is at 100% on deployment-mediawiki01 at least
<marktraceur> So logging is killing it

Beta is back up right now, but I don't believe this bug is fixed in master, correct? (Beta's problem might have been space running out on one of the machines, but since I woke up to both that and this, I want to make sure we find the real issue.)

Dont think so. Going to revert in master

gerritadmin wrote:

Change 174433 had a related patch set uploaded by Paladox:
Fix GESHI version

https://gerrit.wikimedia.org/r/174433

This bug is about the version declared twice. That was fixed by reverting the commit.

Revert "Fix tracking for version"

This reverts commit d69ae1f3ac97404831da292145ad843574a14579.
Change-Id: Ic724f6fe1b1cbc969ac195762bdf517e129cd9dd

But the api doesent detect it.

What I mean by api doesent detect it is it does not detect the version that is in geshi.php instead of it saying 1.0.8.12 in the api it says GESHI_VERSION.