Maniphest T75570

VisualEditor: Improve FileDropHandler API
Open, MediumPublicFeature
Actions

Assigned To

None

Authored By

	Catrope
	Nov 18 2014, 7:29 PM

Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

Description

From comments at https://gerrit.wikimedia.org/r/#/c/173296/1/src/ui/filedrophandlers/ve.ui.DSVFileDropHandler.js :

Right now every child class calls createProgress( insertableDataDeferred.promise() ); in its process() method. This seems like something that should be in the base class instead. Would you ever want to not do that, or pass a different promise?

Child classes should not have to override abort() just to add this.reader.abort();, because this.reader is added by the base class.

Version: unspecified
Severity: enhancement

Details

Reference: bz73570

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:51 AM

• bzimport added a project: Technical-Debt.

• bzimport set Reference to bz73570.

Catrope created this task.Nov 18 2014, 7:29 PM

Jdforrester-WMF added a project: VisualEditor.Nov 24 2014, 6:27 PM

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Nov 24 2014, 6:34 PM

Jdforrester-WMF lowered the priority of this task from High to Medium.Jan 9 2015, 10:55 PM

Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 12:23 PM