Page MenuHomePhabricator

[Regression wmf9]Cannot create a new page in Firefox. Edit button doesn't respond
Closed, ResolvedPublic

Description

switch edit mode fails in Chrome

This manifests in several ways, see the browser test failures at
Chrome: https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/
Firefox: https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/

The common case for Chrome and Firefox:

As a logged-in user with access to VisualEditor, edit any page.
Attempt to switch from the wikitext editor to VE using the dropdown controls.
Nothing happens, VE does not show up. See screen shot.

The Firefox-only issue:

Attempt to edit a new page by supplying a bogus URL, e.g. http://en.m.wikipedia.beta.wmflabs.org/wiki/Foobarbaz

Clicking the edit icon does nothing.


Version: unspecified
Severity: major

Attached:

Screen_Shot_2014-11-18_at_4.55.40_PM.png (744×2 px, 268 KB)

Details

Reference
bz73585

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:52 AM
bzimport set Reference to bz73585.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/LKgERdDV

For the second (FF only):
[10:11:21.144] "[Exception... "Failure" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20141030T090804Z :: EditorOverlay<._loadContent/< :: line 17" data: no]" [object XPCWrappedNative_NoHelper]

Caused by: I2a3eab234338bae6258abcde99144bdd2464805f

VE: confirmed :/

gerritadmin wrote:

Change 174384 had a related patch set uploaded by Florianschmidtwelzow:
Don't try to set cursor on hidden elements

https://gerrit.wikimedia.org/r/174384

This seems to be specific for new pages in Firefox.

Nope, this is not a browser/page specific issue,was happening for me in all pages even in iOS safari.Once you switch to edit source mode the "Edit" button will no longer work from that point on.And then for a new page, it always opens the Edit Source mode first, so thats why its always reproducible for a new page too.

Jon is talking about the Firefox only problem :) The VE problem is right, it doesn't work on all pages :(

Ah got it, so this patch is going to fix for all pages in all browsers?

Unhappily no, this patch adresses the Firefox problem. For now, I haven't had the time to look into it, why VE doesn't work :/

okay,just to keep note, this bug is now in test2 as well after today's deployment since it was regression from wmf9.I will test the fix in test2 once it is merged and backported.

If there are two problems here there should be 2 bugs..

I captured the other issue in bug 73646

gerritadmin wrote:

Change 174384 abandoned by Florianschmidtwelzow:
Don't try to set cursor on hidden elements

Reason:
Function reverted in: I672d04c16f9348f7e08c4f64b339b307276d2a5a

https://gerrit.wikimedia.org/r/174384

Jdlrobson set Security to None.
Jdlrobson subscribed.

I can edit new pages on Firefox so I think this has been fixed. Please reopen if you can still duplicate it.