Surface is not destroyed when you exit VE if you ever opened the save dialog
Closed, ResolvedPublic
Actions

Description

Edit page
Insert table
Load save dialog
Review diff
Resume editing
Exit to read mode discarding changes

Observe the new table still being there, and you can even highlight cells, load the link editor, etc..

Version: unspecified
Severity: normal

Details

Reference: bz73589

	Subject	Repo	Branch	Lines +/-
	Only try to close save dialog before destroying surface if it's currently open	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: rEVED1c04d32d7503: Only try to close save dialog before destroying surface if it's currently open

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:53 AM

• bzimport added projects: VE-deploy-nextup, VisualEditor-Initialisation.

• bzimport set Reference to bz73589.

Jdforrester-WMF created this task.Nov 19 2014, 2:23 AM

Bug 73590 has been marked as a duplicate of this bug. ***

Krenair renamed this task from VisualEditor: Viewing the diff before exiting to read mode without saving leaves the editor active to VisualEditor: Surface is not destroyed when you exit VE if you ever opened the save dialog.Nov 23 2014, 10:30 PM

Krenair set Security to None.

Fixed in https://gerrit.wikimedia.org/r/175217/

Jdforrester-WMF added a project: VisualEditor.Nov 23 2014, 10:47 PM

Jdforrester-WMF moved this task from To Triage to Planned Maintenance on the VisualEditor board.Nov 23 2014, 11:00 PM

Jdforrester-WMF moved this task from Planned Maintenance to Blocked on the VisualEditor board.Nov 24 2014, 1:41 AM

Jdforrester-WMF renamed this task from VisualEditor: Surface is not destroyed when you exit VE if you ever opened the save dialog to Surface is not destroyed when you exit VE if you ever opened the save dialog.Nov 24 2014, 4:48 AM

Jdforrester-WMF added a project: VisualEditor-MediaWiki.

Jdforrester-WMF added a project: VisualEditor-Performance.

Krenair added a project: Patch-For-Review.Nov 24 2014, 7:50 PM

Jdforrester-WMF removed a project: VE-deploy-nextup.Nov 24 2014, 10:02 PM

Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Nov 25 2014, 3:11 AM

Change 175217 merged by jenkins-bot:
Only try to close save dialog before destroying surface if it's currently open

https://gerrit.wikimedia.org/r/175217

Jdforrester-WMF closed this task as Resolved.Nov 25 2014, 11:18 PM

Jdforrester-WMF added a project: WMF-deploy-2014-11-26-(1.25wmf10).

Krenair mentioned this in rEVED1c04d32d7503: Only try to close save dialog before destroying surface if it's currently open.Dec 10 2014, 7:26 PM

Jdforrester-WMF removed a project: Patch-For-Review.Dec 15 2014, 9:22 PM

ori moved this task from Backlog to Done on the VisualEditor-Performance board.Feb 21 2015, 6:13 AM

Jdforrester-WMF added a project: VisualEditor pre-2015 work.Aug 5 2015, 12:59 AM

Surface is not destroyed when you exit VE if you ever opened the save dialogClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Surface is not destroyed when you exit VE if you ever opened the save dialog
Closed, ResolvedPublic
Actions